feat!: change default dump maxSize/limit to infinity

[styfle]

This relates to...

• chore(docs): add request() example for conditionally reading the body #3743 (comment)

Rationale

I think dump() should be able to dump the entire response body, not limited to a max size, you often don't know how big the response body will be.

Changes

N/A

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

• Change default maxSize from 1048576 (1024 * 1024) to null (Infinity)
• Change default limit from 131072 (128 * 1024) to null (Infinity)

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[ronag]

If the response is too big it can cause significant delay before the response is dumped. IMHO it's better to just close the connection in those cases.

[styfle]

@ronag Feel free to make any changes to this PR.

I created this PR since there was no discussion happening on the original docs PR and a DM to @mcollina suggested creating a PR to change the value to infinity.

[mcollina]

If the response is too big it can cause significant delay before the response is dumped. IMHO it's better to just close the connection in those cases.

I agree, but then why do we have a .dump() method to begin with?

Calling .dump() with a limit is dangerous, as users would still need to consume the rest of stream or risk crashing their process.

[ronag]

If the response is too big it can cause significant delay before the response is dumped. IMHO it's better to just close the connection in those cases.

I agree, but then why do we have a .dump() method to begin with?

We have it so that if a user aborts a request with a small response we consume it and re-use the connection rather than killing it and starting a new one for the next request.

Calling .dump() with a limit is dangerous, as users would still need to consume the rest of stream or risk crashing their process.

I don't understand? If the limit is reached then dump will kill the connection.

[mcollina]

Ah I misunderstood this. Then we can close this.

[styfle]

If the limit is reached then dump will kill the connection.

To be clear, if the connection is killed then there is no risk of memory leak or process crash?