fix: throw on retry when payload is consume by downstream #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
climba03003
commented
Jul 3, 2024
f947d7f to
9d41b62
Compare
mcollina
reviewed
Jul 3, 2024
ronag
reviewed
Jul 3, 2024
ronag
reviewed
Jul 3, 2024
Comment on lines
+200
to
+206
| this.abort( | ||
| new RequestRetryError('server does not support the range header and the payload was partially consumed', statusCode, { | ||
| headers, | ||
| data: { count: this.retryCount } | ||
| }) | ||
| ) | ||
| return false |
There was a problem hiding this comment.
Suggested change
| this.abort( | |
| new RequestRetryError('server does not support the range header and the payload was partially consumed', statusCode, { | |
| headers, | |
| data: { count: this.retryCount } | |
| }) | |
| ) | |
| return false | |
| throw new RequestRetryError('server does not support the range header and the payload was partially consumed', statusCode, { | |
| headers, | |
| data: { count: this.retryCount } | |
| }) | |
| ) |
There was a problem hiding this comment.
Are you sure it should throw instead of similar to the others error?
There was a problem hiding this comment.
it's a nit, you can leave it if you want
ronag
approved these changes
Jul 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
* fix: throw on retry when payload is consumed * fixup * fixup (cherry picked from commit 71121e5)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3365 Fixes #3356
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status