Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): remove terminated event listener on redirect #1715

Merged
merged 3 commits into from
Oct 26, 2022
Merged

fix(fetch): remove terminated event listener on redirect #1715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
082325c
fix(fetch): remove terminated event listener on redirect
KhafraDev Oct 18, 2022
394b2ad
fix: use setMaxListeners instead
KhafraDev Oct 19, 2022
e4c7c60
Update lib/fetch/index.js
ronag Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/fetch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ class Fetch extends EE {
this.connection = null
this.dump = false
this.state = 'ongoing'
// 2 terminated listeners get added per request,
// but only 1 gets removed. If there are 20 redirects,
// 21 listeners will be added.
// See https://github.com/nodejs/undici/issues/1711
// TODO (fix): Find and fix root cause for leaked listener.
this.setMaxListeners(21)
ronag marked this conversation as resolved.
Show resolved Hide resolved
}

terminate (reason) {
Expand Down