fix(body mixin): only allow Uint8Array chunks #1550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a regression test for nodejs/node#43838 and discovered that the body mixin methods were still not spec-compliant. According to the stream standards, every chunk must be a Uint8Array when reading a body.
Writing this out because it's very convoluted any might help someone understand this in the future.
p.s.:
.formData()
likely isn't correct still, but I left it untouched.