Fix Node v16 support and update tap (#754)

nodejs · Apr 21, 2021 · da824a8 · da824a8
1 parent 39eba71
commit da824a8
Show file tree

Hide file tree

Showing 44 changed files with 1,035 additions and 1,027 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.16.0, 10.x, 12.3.0, 12.18.0, 12.x, 14.0.0, 14.x, 15.x]
+        node-version: [10.16.0, 10.x, 12.3.0, 12.18.0, 12.x, 14.0.0, 14.x, 15.x, 16.x]
         os: [ubuntu-latest, windows-latest, macOS-latest]
 
     steps:

diff --git a/.taprc b/.taprc
@@ -1,7 +1,7 @@
-esm: false
 ts: false
 jsx: false
 flow: false
 coverage: true
 expose-gc: true
 timeout: 60
+check-coverage: false
diff --git a/lib/core/client.js b/lib/core/client.js
@@ -363,7 +363,7 @@ class Parser extends HTTPParser {
         client[kMaxHeadersSize],
         0
       )
-    } else if (nodeMajorVersion > 12) {
+    } else if (nodeMajorVersion > 12 && nodeMajorVersion < 16) {
       super()
       this.initialize(
         HTTPParser.RESPONSE,
@@ -372,8 +372,16 @@ class Parser extends HTTPParser {
         insecureHTTPParser,
         0
       )
+    } else if (nodeMajorVersion >= 16) {
+      super()
+      this.initialize(
+        HTTPParser.RESPONSE,
+        {},
+        client[kMaxHeadersSize],
+        0
+      )
     } else {
-      super(HTTPParser.RESPONSE, false)
+      super(HTTPParser.RESPONSE)
     }
 
     this.client = client

diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
     "proxyquire": "^2.0.1",
     "snazzy": "^8.0.0",
     "standard": "^14.3.4",
-    "tap": "^14.10.8",
+    "tap": "^15.0.0",
     "tsd": "^0.13.1"
   },
   "pre-commit": [

diff --git a/test/abort-controller.js b/test/abort-controller.js
@@ -64,7 +64,7 @@ for (const { AbortControllerImpl, controllerName } of controllers) {
           bufs.push(buf)
         })
         response.body.on('end', () => {
-          t.strictEqual('hello', Buffer.concat(bufs).toString('utf8'))
+          t.equal('hello', Buffer.concat(bufs).toString('utf8'))
         })
       })
 

diff --git a/test/abort-event-emitter.js b/test/abort-event-emitter.js
@@ -33,7 +33,7 @@ test('Abort before sending request (no body)', (t) => {
         bufs.push(buf)
       })
       response.body.on('end', () => {
-        t.strictEqual('hello', Buffer.concat(bufs).toString('utf8'))
+        t.equal('hello', Buffer.concat(bufs).toString('utf8'))
       })
     })