code review pt2

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
nodejs · Oct 14, 2024 · 8bf6b42 · 8bf6b42
1 parent baaa914
commit 8bf6b42
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 17 deletions.
diff --git a/lib/cache/memory-cache-store.js b/lib/cache/memory-cache-store.js
@@ -366,15 +366,15 @@ class MemoryStoreWritableStream extends Writable {
     super()
     this.#value = value
     this.#value.readLock = true
-    this.#maxEntrySize = maxEntrySize
+    this.#maxEntrySize = maxEntrySize ?? Infinity
   }
 
   get rawTrailers () {
     return this.#value.opts.rawTrailers
   }
 
   /**
-   * @param {Buffer[] | undefined} trailers
+   * @param {string[] | undefined} trailers
    */
   set rawTrailers (trailers) {
     this.#value.opts.rawTrailers = trailers

diff --git a/lib/core/constants.js b/lib/core/constants.js
@@ -112,11 +112,14 @@ Object.setPrototypeOf(headerNameLowerCasedRecord, null)
  */
 const wellknownHeaderNameBuffers = {}
 
+// Note: object prototypes should not be able to be referenced. e.g. `Object#hasOwnProperty`.
+Object.setPrototypeOf(wellknownHeaderNameBuffers, null)
+
 /**
  * @param {string} header Lowercased header
  * @returns {Buffer}
  */
-function getWellknownHeaderNameBuffer (header) {
+function getHeaderNameAsBuffer (header) {
   let buffer = wellknownHeaderNameBuffers[header]
 
   if (buffer === undefined) {
@@ -136,6 +139,5 @@ for (let i = 0; i < wellknownHeaderNames.length; ++i) {
 module.exports = {
   wellknownHeaderNames,
   headerNameLowerCasedRecord,
-  wellknownHeaderNameBuffers,
-  getWellknownHeaderNameBuffer
+  getHeaderNameAsBuffer
 }
diff --git a/lib/core/util.js b/lib/core/util.js
@@ -10,7 +10,7 @@ const nodeUtil = require('node:util')
 const { stringify } = require('node:querystring')
 const { EventEmitter: EE } = require('node:events')
 const { InvalidArgumentError } = require('./errors')
-const { headerNameLowerCasedRecord, getWellknownHeaderNameBuffer } = require('./constants')
+const { headerNameLowerCasedRecord, getHeaderNameAsBuffer } = require('./constants')
 const { tree } = require('./tree')
 
 const [nodeMajor, nodeMinor] = process.versions.node.split('.').map(v => Number(v))
@@ -462,7 +462,7 @@ function encodeHeaders (headers) {
       rawValue = Buffer.from(value)
     }
 
-    const headerBuffer = getWellknownHeaderNameBuffer(header)
+    const headerBuffer = getHeaderNameAsBuffer(header)
 
     rawHeaders[rawHeadersIndex] = headerBuffer
     rawHeadersIndex++

diff --git a/lib/handler/cache-handler.js b/lib/handler/cache-handler.js
@@ -59,22 +59,19 @@ class CacheHandler extends DecoratorHandler {
    * @param {Buffer[]} rawHeaders
    * @param {() => void} resume
    * @param {string} statusMessage
-   * @param {Record<string, string | string[]> | undefined} headers
    * @returns {boolean}
    */
   onHeaders (
     statusCode,
     rawHeaders,
     resume,
-    statusMessage,
-    headers = util.parseHeaders(rawHeaders)
+    statusMessage
   ) {
     const downstreamOnHeaders = () => this.#handler.onHeaders(
       statusCode,
       rawHeaders,
       resume,
-      statusMessage,
-      headers
+      statusMessage
     )
 
     if (
@@ -101,6 +98,8 @@ class CacheHandler extends DecoratorHandler {
       return downstreamOnHeaders()
     }
 
+    const headers = util.parseHeaders(rawHeaders)
+
     const cacheControlHeader = headers['cache-control']
     const contentLengthHeader = headers['content-length']
 

diff --git a/lib/handler/cache-revalidation-handler.js b/lib/handler/cache-revalidation-handler.js
@@ -49,15 +49,13 @@ class CacheRevalidationHandler extends DecoratorHandler {
    * @param {Buffer[]} rawHeaders
    * @param {() => void} resume
    * @param {string} statusMessage
-   * @param {string[] | undefined} headers
    * @returns {boolean}
    */
   onHeaders (
     statusCode,
     rawHeaders,
     resume,
-    statusMessage,
-    headers = undefined
+    statusMessage
   ) {
     // https://www.rfc-editor.org/rfc/rfc9111.html#name-handling-a-validation-respo
     if (statusCode === 304) {
@@ -71,8 +69,7 @@ class CacheRevalidationHandler extends DecoratorHandler {
         statusCode,
         rawHeaders,
         resume,
-        statusMessage,
-        headers
+        statusMessage
       )
     }
   }