Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minutes for 2024-11-20 #19

Merged
merged 1 commit into from
Nov 23, 2024
Merged

chore: minutes for 2024-11-20 #19

merged 1 commit into from
Nov 23, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Nov 20, 2024

Fixes: #18

@nodejs/typescript

meetings/2024-11-20.md Outdated Show resolved Hide resolved
meetings/2024-11-20.md Outdated Show resolved Hide resolved
meetings/2024-11-20.md Outdated Show resolved Hide resolved
@JakobJingleheimer
Copy link
Member

Closes #18

Comment on lines 32 to 40
Marco: No need to support it for the unflagging, it can wait.
Daniel: Right now don’t think it’s a good idea, but not definitive.
Jacob: use engines section of package.json to mitigate some the incompatibility issues
Marco: probably enable it behind a flag
Daniel: monorepo use symlinks so don’t need it
Andrew: monorepo already work, maybe does not work when publishing .ts files internally
Daniel: If users wants to use workspaces, that is already documented
Jacob: monorepo in fact works, tested in codemod
Marco: We believe monorepo use-cases should all work, we will re-evaluate after the feature becomes more stable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not format correctly in markdown (it collapses into a single continuous paragraph), but I don't know how to get it to do so.

meetings/2024-11-20.md Outdated Show resolved Hide resolved
Comment on lines 43 to 53
Jacob: Is volunteers to document how to publish a typescript package on npm
Daniel: ts 5.7 landing tomorrow
Daniel: About the ack from TypeScript team, exciting, the missing piece is providing errors in the IDE but no blockers.
Marco: transform types might always stay behind a flag, source maps should not be enabled by default. Marco should we wait to unflag, for a TS compatible flag?
Daniel: Not a big deal, it’s ok
Conclusion: TS team are ok with unflagging
TS Issue for option to disallow features requiring transformations which are not supported by Node.js' --strip-types: <https://github.com/microsoft/TypeScript/issues/59601>
Andrew/Daniel: The plan is for TS to add the lint flag in TS 5.8 (the next release)
Marco: Documentation was added: <https://nodejs.org/docs/latest/api/typescript.html#type-stripping>
Marco: Talking about next steps, should we ping frontend frameworks?
Daniel: Would be good but not necessary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: collapses into a single paragraph

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@marco-ippolito
Copy link
Member Author

@JakobJingleheimer why your approval is gray? 🤔

@JakobJingleheimer
Copy link
Member

I think I have only read-write permissions on the repo (I think anything lower than maintainer doesn't count).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js TypeScript team Meeting 2024-11-20
3 participants