Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint on CI #550

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Run lint on CI #550

merged 5 commits into from
Jan 7, 2025

Conversation

MattiasBuelens
Copy link
Contributor

This adds a new "Lint" workflow which runs on all branches and pull requests and performs some checks:

  • Runs npm run build, and checks that the generated files exactly match those in the lib/ directory.
  • Runs ESLint, to check that there are no lint errors.
  • Runs Prettier, to check that there are no code formatting issues.

mcollina
mcollina approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5d24fc7 into main Jan 7, 2025
198 checks passed
@MattiasBuelens MattiasBuelens deleted the lint-on-ci branch January 7, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattiasBuelens @mcollina