Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 8.9.4 #320

Merged
merged 9 commits into from
Feb 9, 2018
Merged

Build 8.9.4 #320

merged 9 commits into from
Feb 9, 2018

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Feb 8, 2018

As titled.

I have also updated process-nextick-args.
Fixes #316.

@mcollina
Copy link
Member Author

mcollina commented Feb 8, 2018

> [secure]@2.3.3 write-zuul /home/travis/build/nodejs/[secure]
> printf "ui: tape
browsers:
  - name: $BROWSER_NAME
    version: $BROWSER_VERSION
">.zuul.yml
- testing: microsoftedge @ Windows 10: 16
- restarting: <microsoftedge 16 on Windows 10>
- restarting: <microsoftedge 16 on Windows 10>
- failed: <microsoftedge 16 on Windows 10> (0 failed, 0 passed)
1 browser(s) failed
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [secure]@2.3.3 browser: `npm run write-zuul && zuul --browser-retries 2 -- test/browser.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [secure]@2.3.3 browser script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-02-08T09_57_28_455Z-debug.log

localtunnel/saucelabs is not really working atm.

@vweevers
Copy link
Contributor

vweevers commented Feb 8, 2018

@mcollina FWIW memdown had similar issues, that disappeared when we switched to Sauce Connect (Level/memdown#81) - though it depends on an as-of-yet unmerged change to zuul.

@mcollina
Copy link
Member Author

mcollina commented Feb 8, 2018

@vweevers considering that zuul is not really well maintained, how about we spin up a new project for that? I would prefer to depend on something from npm and not from a github account.

@vweevers
Copy link
Contributor

vweevers commented Feb 8, 2018

SGTM! Can we reduce its scope (Sauce Connect only) to lower the maintenance cost?

@mcollina
Copy link
Member Author

mcollina commented Feb 8, 2018

SGTM! Can we reduce its scope (Sauce Connect only) to lower the maintenance cost?

Yes definitely.

@yoshuawuyts
Copy link

Scaling CI down to just Sauce Connect sounds good! ~ have been frustrated with Zuul for a while too now; having a more reliable solution is definitely a step forward.

@vweevers
Copy link
Contributor

vweevers commented Feb 9, 2018

I should have knocked on wood.. Sauce Labs is now also failing for memdown, with an error similar to #320 (comment). But I think forking zuul to work with Sauce Connect is still a good idea, as it at least removes localtunnel as a point of failure. If you agree I'll open an repo to continue discussion there.

@mcollina
Copy link
Member Author

mcollina commented Feb 9, 2018

@vweevers I also spoke with @feross whom agreed on helping out. I would say go ahead and create a repo and add all of us, I think we can build something that it's easy to maintain.

@mcollina mcollina merged commit f94381c into master Feb 9, 2018
@mcollina mcollina deleted the build-8.9.4 branch February 9, 2018 17:15
@vweevers vweevers mentioned this pull request Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants