Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outreachy: add citgm #958

Merged
merged 1 commit into from
Oct 15, 2016
Merged

outreachy: add citgm #958

merged 1 commit into from
Oct 15, 2016

Conversation

MylesBorins
Copy link
Contributor

here is an extra project for students to apply to.

I think project one is a bit more approachable and malleable, which
should make for a wider audience.

/cc @hackygolucky

@Trott
Copy link
Member

Trott commented Oct 13, 2016

LGTM.

Nit: Might want to define "smoke testing" (or omit/replace the term).

@MylesBorins
Copy link
Contributor Author

@Trott updated PTAL

@zlatanvasovic
Copy link
Contributor

LGTM :shipit:

@Trott
Copy link
Member

Trott commented Oct 13, 2016

LGTM.

Micro-nits:

  • period after 'testing utility rather than a comma (and capitalize the next word, so it -> It)
  • node -> Node.js
  • other peoples code -> other people's code

here is an extra project for students to apply to.

I think project one is a bit more approachable and malleable, which
should make for a wider audience.
@fhemberger fhemberger merged commit b4f6fd1 into nodejs:master Oct 15, 2016
@fhemberger
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants