Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostics): Updated flamegraph tutorial to use better tools #7474

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

wesleytodd
Copy link
Member

Description

The current instructions for generating flamegraphs are functional but result in a pretty bad resulting view. These instructions use the tool maintained by the original creator of flamegraphs, and despite being older and in perl it really ouputs a better result.

Before:
Screenshot 2025-02-03 at 10 07 05 PM

After:
Screenshot 2025-02-03 at 10 07 27 PM

Validation

I have tested these tools, see the screenshots after following the updated guide.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@wesleytodd wesleytodd requested a review from a team as a code owner February 4, 2025 04:10
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 4, 2025 4:14am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as nodejs website. Need to wait diagnostics WG approval before merging.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.71% (739/833) 75.94% (240/316) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 6.613s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Feb 11, 2025
Merged via the queue into nodejs:main with commit e52e6db Feb 11, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants