Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: nodejs.org/about/* leads to 404 #7432

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix: nodejs.org/about/* leads to 404 #7432

merged 1 commit into from
Jan 28, 2025

Conversation

lextm
Copy link
Contributor

@lextm lextm commented Jan 27, 2025

Description

Added the redirect path to the child pages of the About nav link

Validation

Related Issues

If the issue is fixed here, then Azure/app-service-linux-docs#206 is no more needed.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@lextm
Fix: nodejs.org/about/* leads to 404
3988839 
Signed-off-by: Lex Li <425130+lextm@users.noreply.github.com>
@Copilot Copilot bot review requested due to automatic review settings January 27, 2025 21:02
@lextm lextm requested a review from a team as a code owner January 27, 2025 21:02
@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 27, 2025 9:03pm

@lextm lextm mentioned this pull request Jan 27, 2025
Open
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 28, 2025
@ovflowd ovflowd enabled auto-merge January 28, 2025 18:51
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 28, 2025
@ovflowd
Copy link
Member

ovflowd commented Jan 28, 2025

FYI @nodejs/nodejs-website I'm fast tracking this PR :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
 88.71% (739/833) 75.94% (240/316) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.687s ⏱️

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jan 28, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 28, 2025
@ovflowd ovflowd added this pull request to the merge queue Jan 28, 2025
Merged via the queue into nodejs:main with commit 6fed09a Jan 28, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@aymen94 aymen94 aymen94 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Copilot code review Copilot Awaiting requested review from Copilot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lextm @ovflowd @bmuenzenmeyer @aymen94 @AugustinMauroy @canerakdas