fix: Button accessibility #7420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AugustinMauroy
approved these changes
Jan 24, 2025
yeah this PR had me hunting for why we changed it recently in the first place. making sure we are not ping-ponging use cases in a shared component is important |
ovflowd
reviewed
Jan 26, 2025
ovflowd
approved these changes
Jan 26, 2025
I see you saying LGMT, but I bet you meant LGTM, no? |
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
Buttoncomponent, the native event listener provided by the browser for anchors is modified, so in some cases it does not work as it shouldFor example, the download button on the home page with a tab and press enter does not start the download
With this PR, I changed the current approach a little bit so that if there is a
hrefin theprops, the button acts like ananchor, and if there is nohref, it acts like abuttonValidation
The places where the
Buttoncomponent is used in the preview must be accessibleRelated Issues
related to #7390, #7287, #7247
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.