Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make fnm an official installation method #7400

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore: make fnm an official installation method #7400

merged 1 commit into from
Jan 16, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jan 10, 2025

This PR makes fnm an officially recommended method after checking requirements with fnm's maintainer.

@ovflowd
chore: make fnm an official installation method
868e020 
Signed-off-by: Claudio W <cwunder@gnome.org>
@ovflowd ovflowd requested a review from a team as a code owner January 10, 2025 21:09
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 10, 2025 9:09pm

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Jan 10, 2025 •
edited
Loading

Claudio could you update the pr description to link the fnm issue that validate the official installation method ? just to get the background

@ovflowd
Copy link
Member Author

ovflowd commented Jan 15, 2025

@nodejs/nodejs-website could I get a review?

AugustinMauroy
AugustinMauroy approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member Author

ovflowd commented Jan 16, 2025

Claudio could you update the pr description to link the fnm issue that validate the official installation method ? just to get the background

Schniz/fnm#1357

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 16, 2025
@ovflowd ovflowd enabled auto-merge January 16, 2025 06:17
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
 87.51% (736/841) 74.14% (238/321) 86.58% (142/164)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.439s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Jan 16, 2025
@ovflowd ovflowd mentioned this pull request Jan 16, 2025
Open
Merged via the queue into main with commit a21e72b Jan 16, 2025
16 checks passed
@ovflowd ovflowd deleted the chore-fnm-official branch January 16, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@araujogui araujogui araujogui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovflowd @AugustinMauroy @araujogui