-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): implements Orama searchbox #6908
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry @micheleriva this has been idle for too long - it's been a messy few weeks. Are you looking for any particular feedback on the approach? |
Looks like this is a draft yet, and most of the styles feel broken 🤔 |
Hey @bmuenzenmeyer, @ovflowd I'm sorry, I completely missed your comments. We found some bugs in the searchbox and dedicated more time to stabilize it. We've been testing it for weeks on other websites so we believe it is finally ready. I still have to fix a small couple of things, then I'll open it for review 🙏 |
FYI @micheleriva build is failing:
Did you try a prod build locally? |
18f2004
to
b279f6f
Compare
Also it'd be great if there was some margin between the results |
This comment was marked as resolved.
This comment was marked as resolved.
OOC - Is there any way we can style the search button on the Navigation bar? It feels a bit fatty and different from the OG design 👀 |
Currently we do not provide all possible customizations. We are going to work on it soon. |
a105511
to
32e70b2
Compare
@ovflowd I've addressed you new comments, but dropped a reply on one of them. Would you mind to check? Thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
32e70b2
to
cf3438e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
@ovflowd Hi! |
I resolved two of the outdated ones - it looks like the other two might still be active? |
Yes! I believe both of them are from @ovflowd. One of them outdated and the other one is addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfortunately reluctant with some of the code choices here, but I believe they can be addressed in the future.
Let's get this merged.
Co-authored-by: Rodrigo José Borba Fernandes <rodrigoj.borba@gmail.com>
Co-authored-by: Rodrigo José Borba Fernandes <rodrigoj.borba@gmail.com>
Description
As discussed with @ovflowd, this PR implements the official Orama Searchbox.
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.