Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): implements Orama searchbox #6908

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

micheleriva
Copy link
Contributor

Description

As discussed with @ovflowd, this PR implements the official Orama Searchbox.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 3, 2024 4:10pm

@bmuenzenmeyer
Copy link
Collaborator

Sorry @micheleriva this has been idle for too long - it's been a messy few weeks. Are you looking for any particular feedback on the approach?

@ovflowd
Copy link
Member

ovflowd commented Jul 31, 2024

Looks like this is a draft yet, and most of the styles feel broken 🤔

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.2% (580/643) 72.08% (173/240) 93.96% (109/116)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 4.924s ⏱️

@micheleriva
Copy link
Contributor Author

Hey @bmuenzenmeyer, @ovflowd I'm sorry, I completely missed your comments. We found some bugs in the searchbox and dedicated more time to stabilize it.

We've been testing it for weeks on other websites so we believe it is finally ready. I still have to fix a small couple of things, then I'll open it for review 🙏

@micheleriva micheleriva marked this pull request as ready for review August 21, 2024 18:33
@micheleriva micheleriva requested a review from a team as a code owner August 21, 2024 18:33
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Aug 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 21, 2024
@ovflowd
Copy link
Member

ovflowd commented Aug 21, 2024

FYI @micheleriva build is failing:

@nodejs/website:build: Error: 
@nodejs/website:build:   x Expression expected
@nodejs/website:build:      ,-[128:1]

Did you try a prod build locally?

@ovflowd
Copy link
Member

ovflowd commented Aug 29, 2024

image

It feels like the results are less obvious.

@ovflowd
Copy link
Member

ovflowd commented Aug 29, 2024

Also it'd be great if there was some margin between the results

@ovflowd

This comment was marked as resolved.

@ovflowd
Copy link
Member

ovflowd commented Nov 28, 2024

OOC - Is there any way we can style the search button on the Navigation bar? It feels a bit fatty and different from the OG design 👀

@rjborba
Copy link
Contributor

rjborba commented Nov 29, 2024

OOC - Is there any way we can style the search button on the Navigation bar? It feels a bit fatty and different from the OG design 👀

Currently we do not provide all possible customizations. We are going to work on it soon.
But if you want to costumize the roundness of the button you can define --radius-m variable.

@rjborba rjborba force-pushed the feat/adds-orama-searchbox branch from a105511 to 32e70b2 Compare November 29, 2024 16:37
@rjborba
Copy link
Contributor

rjborba commented Nov 29, 2024

@ovflowd I've addressed you new comments, but dropped a reply on one of them. Would you mind to check? Thank you!

@ovflowd

This comment was marked as resolved.

@rjborba

This comment was marked as resolved.

@rjborba rjborba force-pushed the feat/adds-orama-searchbox branch from 32e70b2 to cf3438e Compare December 3, 2024 16:09
@rjborba

This comment was marked as resolved.

@rjborba
Copy link
Contributor

rjborba commented Dec 4, 2024

@ovflowd Hi!
I do not think I am authorized to resolve conversations here. It looks like 6 of them still unresolved

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Dec 5, 2024

I do not think I am authorized to resolve conversations here. It looks like 6 of them still unresolved

I resolved two of the outdated ones - it looks like the other two might still be active?

@rjborba
Copy link
Contributor

rjborba commented Dec 5, 2024

I do not think I am authorized to resolve conversations here. It looks like 6 of them still unresolved

I resolved two of the outdated ones - it looks like the other two might still be active?

Yes! I believe both of them are from @ovflowd. One of them outdated and the other one is addressed

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfortunately reluctant with some of the code choices here, but I believe they can be addressed in the future.

Let's get this merged.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 15, 2024
@ovflowd ovflowd enabled auto-merge December 15, 2024 01:53
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 15, 2024
@ovflowd ovflowd added this pull request to the merge queue Dec 15, 2024
@ovflowd ovflowd disabled auto-merge December 15, 2024 02:02
Merged via the queue into nodejs:main with commit d572121 Dec 15, 2024
18 checks passed
avivkeller pushed a commit to avivkeller/nodejs.org that referenced this pull request Jan 10, 2025
Co-authored-by: Rodrigo José Borba Fernandes <rodrigoj.borba@gmail.com>
avivkeller pushed a commit to avivkeller/nodejs.org that referenced this pull request Jan 10, 2025
Co-authored-by: Rodrigo José Borba Fernandes <rodrigoj.borba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Issues with Scrolling and Focus in WithSearchBox Modal
9 participants