Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated the legacy guide Backpressuring in Streams to the learn section #6261

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@
"modules": "Modules",
"publishingNodeApiModules": "How to publish a Node-API package"
}
},
"backpressuring": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category should be "streams", not "Backpressuring". Can you make these changes? (Since it will require changes in many files?)

Also, the link should probably be /learn/streams/backpressuring-in-streams

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this guide should be in the "Modules" category 🤔

"links": {
"backpressuring": "Backpressuring",
"backpressuringInStreams": "Backpressuring In Streams"
}
}
},
"about": {
Expand Down
9 changes: 9 additions & 0 deletions navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,15 @@
"label": "components.navigation.learn.modules.links.publishingNodeApiModules"
}
}
},
"backpressuring": {
"label": "components.navigation.learn.backpressuring.links.backpressuring",
"items": {
"backpressuringInStreams": {
"link": "/learn/backpressuring/backpressuring-in-streams",
"label": "components.navigation.learn.backpressuring.links.backpressuringInStreams"
}
}
}
}
},
Expand Down
1 change: 0 additions & 1 deletion pages/en/guides/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ layout: docs.hbs

- [Anatomy of an HTTP Transaction](/guides/anatomy-of-an-http-transaction/)
- [Working with Different Filesystems](/guides/working-with-different-filesystems/)
- [Backpressuring in Streams](/guides/backpressuring-in-streams/)
- [ABI Stability](/guides/abi-stability/)
Loading