fix: de-emphasize copy to clipboard button #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
@bmuenzenmeyer does it make sense to keep the green colour on light theme? Like keeping the gray on dark theme and green on light theme? I have the feeling that within the light theme the gray button is more emphasized than the green one. |
ovflowd
approved these changes
Jan 14, 2024
|
I thought about that but the codebox is always dark, so this still seems appropriate to me. Open to more thoughts, or iterating on this for a bit. |
AugustinMauroy
approved these changes
Jan 15, 2024
aymen94
approved these changes
Jan 15, 2024
canerakdas
reviewed
Jan 15, 2024
canerakdas
approved these changes
Jan 15, 2024
bmuenzenmeyer
commented
Jan 17, 2024
ovflowd
approved these changes
Jan 17, 2024
|
@bmuenzenmeyer apparently the merge queue is failing. You might want to check why 👀 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
1a8280e to
cd866c2
Compare
|
I mean yea, we updated the tailwind prettier plugin, so main branch has new rules 👀 |
cd866c2 to
1830871
Compare
|
cursed pr |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
De-emphasizes the copy to clipboard button. also removed the homepage customization. yes, this is a deviation of the figma- but now met with real content, especially repeated examples are distracting. this is a tertiary act for the site, it should not have primary/action color
Validation
same homepage
less busy examples within content
Related Issues
closes #6244
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.