fix(test): dir name #5354

AugustinMauroy · 2023-05-03T22:05:40Z

use __tests__ not __test__

feat(unit-test): introduce unit test

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

…ooks (#5281)

Co-authored-by: Michael Esteban <mickel13@gmail.com>

chore: next lock to versin 13.2.0

Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com>

) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

…mplates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

…ies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx

* chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries

fix(package.json) lint:fix missing slashes

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>

Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

Harkunwar · 2023-05-06T12:26:49Z

I beleive this test is not needed as it's already captured by storybook.

https://github.com/nodejs/nodejs.org/tree/major/website-redesign/components/Home/NodeFeatures

Harkunwar

Could you please delete the components/Home/NodeFeatures/__tests__ directory since it's not needed anymore.

AugustinMauroy · 2023-05-07T08:15:23Z

Hey @Harkunwar I don't saw what do you mean.
Can you give more explaining

changes applied

Harkunwar · 2023-05-07T15:03:34Z

Hey @Harkunwar I don't saw what do you mean.
Can you give more explaining

Since we're using Storybook to automatically do Snapshot testing, we don't need to write unit tests in Jest to do them anymore, which is why I said you could delete the test as well as the snapshot. Any component written in storybook will automatically have a snapshot generated instead of a manual test.

Harkunwar · 2023-05-11T06:33:37Z

@ovflowd Are we waiting for anything, should we merge this?

AugustinMauroy · 2023-05-11T08:18:14Z

@Harkunwar I thinks you can merge. Claudio are too busy this week.

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

* test(snapshot): Migrate snapshot tests to storybook (#5340) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> fixed styleling misconfig and fixed storybooks (#5281) fix storybook styles, imports, typescript config and dependencies (#5319 fix(package.json) Lint command is missing slashes (#5321 fix storybook local development mode (#5335) fix(i18n): translation key (#5347) * chore: no-unused-vars ignores pattern starting with _ (#5363) * Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369) Add clarity to step 4 based on clone method Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * fix(test): dir name (#5354) * feat(stability): migrate component (#5339) * Migrate JsonLink component (#5370) * Migrate JsonLink component Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Add storybook snap and robot icon Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Remove IconContext provider Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> --------- Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376) * refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: Add MUI Config and Theme Provider (#5368) * feat: Add MUI Config and Theme Provider * added createTheme * refactor themeConfig * feat(theme): Fix linting and package-lock * feat(theme): Add emotion styled and emtion react --------- Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * refactor(delete): duplicate test file (#5377) refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat(useClickOutside): introduce (#5359) * feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: build --------- Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> --------- Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> Co-authored-by: Vessy <46304479+Ve33y@users.noreply.github.com> Co-authored-by: Mert Can Altın <mertgold60@gmail.com>

AugustinMauroy and others added 30 commits April 15, 2023 10:17

feat(unit-test): introduce unit test on website redesign branch (#5178

bd8a46e

feat(unit-test): introduce unit test

chore(redesign): added new folders for new layouts and new pages

80039d3

chore(minor): just a tiny design nitpick

cdbc4b4

chore: set up storybook (#5191) (#5214)

df79868

feat(ignore): add storyBook (#5229)

ecbec61

chore: set up testing-library jest extend (#5231)

a2a4bd8

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

chore(dependencies): updated dependencies

67999b6

feat: create section title component (#5237)

48d6c91

Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

📎 chore(migration): migrate banner component (#5233)

6ce6923

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

feat: migrate AnimatedPlaceholder component (#5238

f9d9765

Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.

feat: create article alert component (#5243)

9311785

chore(dependencies): updated dependencies

06ce22b

fix: formatted file

386a458

chore: updated deps

0240b9b

feat: migrate blockquote component (#5259)

ffa9a3e

feat(stylelint,storybook): fixed styleling misconfig and fixed storyb…

390c2da

…ooks (#5281)

feat: create article data tag component (#5280)

e121b83

feat: migrate AuthorList component and add story 🎉 (#5277)

d7a154d

Co-authored-by: Michael Esteban <mickel13@gmail.com>

chore: lock nextjs to 13.2.0 (#5301

620f58e

chore: next lock to versin 13.2.0

feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236

bb46dfe

) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

chore: updated contributing guidelines, eslint rules and storybook te…

bfcabb9

…mplates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

chore: contributing quick fix of example

f6dc39f

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

chore: story guide and react spreading

2eba819

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

chore: remove base styles from old styling

86b60f3

fix(package.json) Lint command is missing slashes (#5321

5891807

fix(package.json) lint:fix missing slashes

moved DataTag to components/Api (#5317)

ca8b5ab

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>

hot-fix: dependency updates and fix dev runtime

c2aeeaa

Merge branch 'major/website-redesign' into fix-test

63e585f

Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

vercel bot temporarily deployed to Preview – nodejs-org May 4, 2023 13:44 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:44 Inactive

Merge branch 'major/website-redesign' into fix-test

7fe2ec1

vercel bot temporarily deployed to Preview – nodejs-org May 6, 2023 10:18 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 6, 2023 10:19 Inactive

Harkunwar previously requested changes May 6, 2023

View reviewed changes

update with feedback

55f02c9

vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 08:20 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 08:21 Inactive

ovflowd enabled auto-merge (squash) May 7, 2023 09:42

Harkunwar approved these changes May 7, 2023

View reviewed changes

Merge branch 'major/website-redesign' into fix-test

2439f69

vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 08:18 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:19 Inactive

Harkunwar disabled auto-merge May 11, 2023 19:17

Merge branch 'major/website-redesign' into fix-test

d24f85b

vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 19:21 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 19:22 Inactive

Harkunwar merged commit 49efa04 into nodejs:major/website-redesign May 11, 2023

Ve33y pushed a commit to Ve33y/nodejs.org that referenced this pull request May 12, 2023

fix(test): dir name (nodejs#5354)

c3e9ab4

Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>

ovflowd pushed a commit that referenced this pull request May 24, 2023

fix(test): dir name (#5354)

c6e4f6a

ovflowd pushed a commit that referenced this pull request May 24, 2023

fix(test): dir name (#5354)

b94cb5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(test): dir name #5354

fix(test): dir name #5354

AugustinMauroy commented May 3, 2023

Harkunwar commented May 6, 2023

Harkunwar left a comment

AugustinMauroy commented May 7, 2023

Harkunwar commented May 7, 2023

Harkunwar commented May 11, 2023

AugustinMauroy commented May 11, 2023

fix(test): dir name #5354

fix(test): dir name #5354

Conversation

AugustinMauroy commented May 3, 2023

Harkunwar commented May 6, 2023

Harkunwar left a comment

Choose a reason for hiding this comment

AugustinMauroy commented May 7, 2023

Harkunwar commented May 7, 2023

Harkunwar commented May 11, 2023

AugustinMauroy commented May 11, 2023