Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(website redesign) Feat(shellbox): migration #5234

Merged
merged 55 commits into from
May 3, 2023
Merged

(website redesign) Feat(shellbox): migration #5234

merged 55 commits into from
May 3, 2023

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Apr 5, 2023

  • Introduce shellBox in commonComponents

Related to #5193

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner April 5, 2023 13:44
@AugustinMauroy AugustinMauroy changed the base branch from main to major/website-redesign April 5, 2023 13:45
@AugustinMauroy AugustinMauroy marked this pull request as draft April 5, 2023 13:45
@shanpriyan shanpriyan added the website redesign Issue/PR part of the Node.js Website Redesign label Apr 5, 2023
.storybook/main.js Outdated Show resolved Hide resolved
components/CommonComponents/ShellBox/index.stories.tsx Outdated Show resolved Hide resolved
i18n/locales/es.json Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Outdated Show resolved Hide resolved
@ovflowd
Copy link
Member

ovflowd commented Apr 6, 2023

BTW as mentioned in other PRs the folder should be components/Common

@tniessen
Copy link
Member

tniessen commented Apr 6, 2023

Is there some context on this somewhere? I don't see any helpful comments or documentation, nor a reference to previous related work. Is this effectively a fancy <pre> for shell code?

@AugustinMauroy
Copy link
Member Author

@tniessen It's an component form nodejs.dev use on index page.
So if you have any question say it.

@tniessen
Copy link
Member

tniessen commented Apr 6, 2023

So if you have any question say it.

@AugustinMauroy I did:

Is this effectively a fancy <pre> for shell code?

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Apr 6, 2023

Is this effectively a fancy <pre> for shell code?

yes and no. it's use to do this.

Capture d’écran 2023-04-06 à 17 16 42

So it's never use to do this

  ```js
  const a = 42
  '``

@manishprivet
Copy link
Member

Is there some context on this somewhere? I don't see any helpful comments or documentation, nor a reference to previous related work.

@tniessen The reference issue for this PR is here at #5193

@AugustinMauroy AugustinMauroy marked this pull request as ready for review April 9, 2023 19:47
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but good work so far :)

components/Common/ShellBox/__tests__/index.test.tsx Outdated Show resolved Hide resolved
components/Common/ShellBox/index.stories.tsx Outdated Show resolved Hide resolved
components/Common/ShellBox/index.stories.tsx Outdated Show resolved Hide resolved
components/Common/ShellBox/index.tsx Outdated Show resolved Hide resolved
i18n/locales/en.json Outdated Show resolved Hide resolved
i18n/locales/es.json Outdated Show resolved Hide resolved
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there. Left some more comments and I'm curious about the similarities of ShellBox and CodeBox and if the two should be just one component with two different flavours

components/Common/ShellBox/__tests__/index.test.tsx Outdated Show resolved Hide resolved
components/Common/ShellBox/__tests__/index.test.tsx Outdated Show resolved Hide resolved
components/Common/ShellBox/__tests__/index.test.tsx Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Outdated Show resolved Hide resolved
hooks/useCopyToClipboard.ts Show resolved Hide resolved
hooks/useCopyToClipboard.ts Show resolved Hide resolved
components/CommonComponents/ShellBox/index.tsx Outdated Show resolved Hide resolved
@ovflowd ovflowd force-pushed the major/website-redesign branch 2 times, most recently from 5cdab56 to 0240b9b Compare April 15, 2023 08:17
AugustinMauroy and others added 7 commits April 15, 2023 22:45
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Apr 30, 2023

If I have understood correctly, I have answered your questions @mikeesto 😁

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 30, 2023 21:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 21:58 Inactive
@mikeesto
Copy link
Member

mikeesto commented May 1, 2023

Thanks @AugustinMauroy . Sorry to be a pain but the Without Text to Copy Jsx story doesn't seem quite right. When I copy that, I get <span><strong>$</strong>hello world</span> on my clipboard?

Could you also confirm if the syntax highlighting is meant to be part of this PR?

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented May 1, 2023

Yup they are a problem with JSX and copy. and style is not an highlight it's style adde by InstallTabs.
But for the JSX copy I don't have any idea. RenderToString from react-server so it will increase the bundle size so no good. createRoot was not good because it's create a root 😆. So I'm void of idea.

@ovflowd
Copy link
Member

ovflowd commented May 1, 2023

story doesn't seem quite right. When I copy that, I get $hello world on my clipboard?

The purpose of that Story is just to remove the "textToCopy" and use the children as the "text" to copy. So the Story is working correctly, of course the children could be updated to remove the $, but it's just an example.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We're ready to get this merged, but I left two little comments if they could be addressed :)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 1, 2023 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 1, 2023 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 1, 2023 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 1, 2023 16:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 2, 2023 01:49 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 2, 2023 01:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 2, 2023 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 2, 2023 22:58 Inactive
@AugustinMauroy
Copy link
Member Author

I thinks we can merge

@ovflowd ovflowd merged commit d5fbf51 into nodejs:major/website-redesign May 3, 2023
ovflowd added a commit that referenced this pull request May 3, 2023
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
araujogui pushed a commit to araujogui/nodejs.org that referenced this pull request May 8, 2023
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
ovflowd added a commit that referenced this pull request May 14, 2023
* feat(unit-test): introduce unit test on website redesign branch (#5178

feat(unit-test): introduce unit test

* chore(minor): just a tiny design nitpick

* chore: set up storybook (#5191) (#5214)

* chore: set up testing-library jest extend (#5231)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

* chore(dependencies): updated dependencies

* feat: create section title component (#5237)

Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* 📎 chore(migration): migrate banner component (#5233)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: migrate AnimatedPlaceholder component (#5238

Migrate AnimatedPlaceholder component from nodejs.dev
and create a new Story.

* feat: create article alert component (#5243)

* feat: migrate blockquote component (#5259)

* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)

* feat: create article data tag component (#5280)

* feat: migrate AuthorList component and add story 🎉 (#5277)

Co-authored-by: Michael Esteban <mickel13@gmail.com>

* chore(migration): migrate language selector component (#5266)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>

* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

* chore: contributing quick fix of example

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* chore: story guide and react spreading

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* chore: remove base styles from old styling

* chore: fix storybook styles, imports, typescript config and dependencies (#5319

* chore: optimises tsconfig

* chiore: add missing dependencies

* chore: type storybook constants

* chore: styles moved styles to somewhere else

* chore: add global json type definition

* chore: i18n aria-label instead of sr-only

* chore: added open sans font family and space between imports

* chore: moved styles and fixed styles and updated banner stories

* fix: stylelint rules

* chore: updated tsconfig

* chore: fix tests

* fix: darkmodetoggle test

* chore: stories use index.stories.tsx

* chore: adopt turborepo (#5316

* chore: revert pnpm use plain npm

* fix: package.json

* chore: remove warnings and add node_env

* chore: cross-env

* fix: fix turbo pipelines

* chore: only cache certain files

* chore: turbo shouldn't care about coverage outputs

* chore: proper inputs and outputs for pipelines

* chore: do not store some outputs and updated inputs for lint

* chore: added prettier configs

* chore: remove console.info

* chore: updated inputs of all other entries

* fix(package.json) Lint command is missing slashes (#5321

fix(package.json) lint:fix missing slashes

* moved `DataTag` to `components/Api` (#5317)

Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>

* hot-fix: dependency updates and fix dev runtime

* chore: updated start command

* migration(Layout): newFooter (#5320)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: migrate EditLink component (#5271)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* feat(blog) Migrate BlogCard component (#5323)

Co-authored-by: Michael Esteban <mickel13@gmail.com>

* Issue#5307 - Add framer-motion to the dependency list (#5318)

* chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>

* chore: add remote turbo cache and simplified gh actions cache

* chore: updated cache rules

* chore: more cache rules

---------

Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>

* chore: fix storybook local development mode (#5335)

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* chore: migrate releases types (#5324)

* hotfix: first element no margin-top

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* chore: updated dependencies

* chore: vercel enable middleware and i18n redirection (#5300)

* feat(unit-test): introduce unit test on website redesign branch (#5178

feat(unit-test): introduce unit test

* chore: set up storybook (#5191) (#5214)

* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)

* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>

* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

* chore: fix storybook styles, imports, typescript config and dependencies (#5319

* chore: optimises tsconfig

* chiore: add missing dependencies

* chore: type storybook constants

* chore: styles moved styles to somewhere else

* chore: add global json type definition

* chore: i18n aria-label instead of sr-only

* chore: added open sans font family and space between imports

* chore: moved styles and fixed styles and updated banner stories

* fix: stylelint rules

* chore: updated tsconfig

* chore: fix tests

* fix: darkmodetoggle test

* chore: stories use index.stories.tsx

* chore: adopt turborepo (#5316

* chore: revert pnpm use plain npm

* fix: package.json

* chore: remove warnings and add node_env

* chore: cross-env

* fix: fix turbo pipelines

* chore: only cache certain files

* chore: turbo shouldn't care about coverage outputs

* chore: proper inputs and outputs for pipelines

* chore: do not store some outputs and updated inputs for lint

* chore: added prettier configs

* chore: remove console.info

* chore: updated inputs of all other entries

* feat(stability): migrate component

* chore(snapshot): update

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* Update components/Api/Stability/index.tsx

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* fea(stability): update stories + fix

* Update components/Api/Stability/index.stories.tsx

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* fix(i18n): update turkish language direction (#5182)

* chore: rollback CODEOWNER changes (#5183)

* Sync: merge `major/website-redesign` into `main` (#5356)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>

* feat(stability): update snapshot

* Update components/Api/Stability/index.tsx

Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

* code format

* Update components/Api/Stability/index.tsx

Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
ovflowd added a commit that referenced this pull request May 18, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: create codebox component

* feat: add pointer to copy button

* feat: add shell support

* feat: use code element instead of pre

* chore: fix eslint issues

* refactor: remove shell codebox

* refactor: use react.fc type

* refactor: remove duplicate encoding

* refactor: use pre element for codebox

* style: some eol

* style: some eol

* refactor: use pre element for codebox

* chore: create inlinecode story

* refactor: create inline code story type

* chore: revert .browserslistrc

* test: remove duplicated test

* test: remove beginning space on code

* refactor: setup userEvent on tests

* refactor: remove useless async

* test: manual mock isomorphic-dompurify

* fix: some fixes

* chore: create multi lang story

* test: snapshot before and after switch lang

* refactor: inline mock

* refactor: use decorators

* chore: split inlinecode component

* feat: add selected lang state

* refactor: add inlinecode decorator

* refactor: remove duplicate classes

* chore: revert .browserslistrc

* test: fix tests

* chore: wip

* feat: use story component arg

* style: stories

* test: remove i18n from clipboard test

* chore: migrate pagination component (#5331)

Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* chore: add a proper decorated component

* refactor: decorated inline code

* Chore(node feat) (#5338)

Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* (website redesign) Feat(shellbox): migration (#5234)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>

* fix(i18n): translation key (#5347)

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat: add hover states

* chore: fix rebase leftovers

* chore: update snapshots

* chore: install @types/prismjs

* Update index.stories.tsx

Signed-off-by: Claudio Wunder <cwunder@gnome.org>

* chore: remove duplicate snapshots

* chore: remove duplicate snapshot

---------

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website redesign Issue/PR part of the Node.js Website Redesign
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants