Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anatomy of an HTTP Transaction - Fix typo #392

Merged
1 commit merged into from
Nov 29, 2015
Merged

Conversation

taueres
Copy link
Contributor

@taueres taueres commented Nov 29, 2015

No description provided.

@Trott
Copy link
Member

Trott commented Nov 29, 2015

LGTM

@ghost
Copy link

ghost commented Nov 29, 2015

LGTM!

ghost pushed a commit that referenced this pull request Nov 29, 2015
Anatomy of an HTTP Transaction - Fix typo
@ghost ghost merged commit 2ab232f into nodejs:master Nov 29, 2015
@Trott
Copy link
Member

Trott commented Nov 29, 2015

Actually, one nit: The line that's edited is now 81 chars long, but the file is wrapped at 80 chars. Can you wrap the last word to the next line?

@ghost
Copy link

ghost commented Nov 29, 2015

should i revert the merge, @Trott?

@Trott
Copy link
Member

Trott commented Nov 29, 2015

Nah, it's a nit. You can leave it. (In my opinion anyway.) If someone wants to fix it in another PR, that would be fine by me. Or not. Whatever. Someone else may care more about the 80-char wrap than me. @bengl maybe?

@ghost
Copy link

ghost commented Nov 29, 2015

i'll do it real quick

@ghost
Copy link

ghost commented Nov 29, 2015

#393

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants