Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in documentation #8326

Closed
wants to merge 1 commit into from
Closed

Conversation

hubertmine
Copy link
Contributor

@hubertmine hubertmine commented Aug 29, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Aug 29, 2016
@hubertmine
Copy link
Contributor Author

Fix documentation

@addaleax
Copy link
Member

Looks good to me, thank you for the PR! Could you update the commit message so that it starts with doc: and is all-lowercase, though?

@mscdex
Copy link
Contributor

mscdex commented Aug 29, 2016

LGTM

@hubertmine hubertmine changed the title Fix typo in documentation doc: fix typo in documentation Aug 29, 2016
@mcollina
Copy link
Member

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Aug 29, 2016

LGTM

@lpinca
Copy link
Member

lpinca commented Aug 30, 2016

LGTM

lpinca pushed a commit to lpinca/node that referenced this pull request Sep 1, 2016
PR-URL: nodejs#8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Sep 1, 2016

Landed in f7dd3bc

@lpinca lpinca closed this Sep 1, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants