Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-util-sigint-watchdog FreeBSD flaky #7932

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 1, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test util

Description of change

Test is currently failing intermittently on FreeBSD only.

Refs: #7919

@Trott Trott added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Aug 1, 2016
@Trott
Copy link
Member Author

Trott commented Aug 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3475/

EDIT: Build failure on FreeBSD. Running this on FreeBSD is kind of important, I guess. Let's try again: https://ci.nodejs.org/job/node-test-pull-request/3476/

EDIT: Windows build failure that time. No tests on Windows seems like a bad way to go, even for a tiny change like this, so let's try another time: https://ci.nodejs.org/job/node-test-pull-request/3477/

@Trott
Copy link
Member Author

Trott commented Aug 1, 2016

CI is green.

@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Aug 1, 2016

LGTM, but perhaps we should evaluate #7933 as a fix first.

@jasnell
Copy link
Member

jasnell commented Aug 4, 2016

Going to label this as blocked on #7933 for the time being then.

@jasnell jasnell added the blocked PRs that are blocked by other issues or PRs. label Aug 4, 2016
@Trott
Copy link
Member Author

Trott commented Aug 4, 2016

It is not blocked by that PR. It can land immediately. But if that PR lands first, then this becomes unnecessary.

@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label Aug 4, 2016
@addaleax
Copy link
Member

Closing this because #7933 landed. :)

@addaleax addaleax closed this Aug 11, 2016
@Trott Trott deleted the freebsd-status branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants