Backport most of the added: info

CONTRIBUTING.md

@@ -151,6 +151,9 @@ $ ./configure && make -j8 test
 Make sure the linter is happy and that all tests pass. Please, do not submit
 patches that fail either check.
 
+Running `make test` will run the linter as well unless one or more tests fail.
+If you want to run the linter without running tests, use `make lint`.
+
 If you are updating tests and just want to run a single test to check it, you
 can use this syntax to run it exactly as the test harness would:
 

Makefile

@@ -108,7 +108,7 @@ cctest: all
 
 v8:
 	tools/make-v8.sh v8
-	$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
+	$(MAKE) -C deps/v8 $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)
 
 test: | cctest  # Depends on 'all'.
 	$(PYTHON) tools/test.py --mode=release doctool message pseudo-tty parallel sequential -J
@@ -227,22 +227,22 @@ test-timers:
 test-timers-clean:
 	$(MAKE) --directory=tools clean
 
-test-v8:
+test-v8: v8
 	# note: performs full test unless QUICKCHECK is specified
 	deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
         --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
         --no-presubmit \
         --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
 	 $(TAP_V8)
 
-test-v8-intl:
+test-v8-intl: v8
 	# note: performs full test unless QUICKCHECK is specified
 	deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
         --mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
         --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
         $(TAP_V8_INTL)
 
-test-v8-benchmarks:
+test-v8-benchmarks: v8
 	deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
         --download-data $(QUICKCHECK_ARG) --no-presubmit \
         --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \

README.md

@@ -170,6 +170,7 @@ information about the governance of the Node.js project, see
 * [benjamingr](https://github.com/benjamingr) - **Benjamin Gruenbaum** <benjamingr@gmail.com>
 * [bmeck](https://github.com/bmeck) - **Bradley Farias** <bradley.meck@gmail.com>
 * [brendanashworth](https://github.com/brendanashworth) - **Brendan Ashworth** <brendan.ashworth@me.com>
+* [bzoz](https://github.com/bzoz) - **Bartosz Sosnowski** <bartosz@janeasystems.com>
 * [calvinmetcalf](https://github.com/calvinmetcalf) - **Calvin Metcalf** <calvin.metcalf@gmail.com>
 * [claudiorodriguez](https://github.com/claudiorodriguez) - **Claudio Rodriguez** <cjrodr@yahoo.com>
 * [domenic](https://github.com/domenic) - **Domenic Denicola** <d@domenic.me>
@@ -186,6 +187,7 @@ information about the governance of the Node.js project, see
 * [joaocgreis](https://github.com/joaocgreis) - **João Reis** <reis@janeasystems.com>
 * [julianduque](https://github.com/julianduque) - **Julian Duque** <julianduquej@gmail.com>
 * [JungMinu](https://github.com/JungMinu) - **Minwoo Jung** <jmwsoft@gmail.com>
+* [lance](https://github.com/lance) - **Lance Ball** <lball@redhat.com>
 * [lxe](https://github.com/lxe) - **Aleksey Smolenchuk** <lxe@lxe.co>
 * [matthewloring](https://github.com/matthewloring) - **Matthew Loring** <mattloring@google.com>
 * [mcollina](https://github.com/mcollina) - **Matteo Collina** <matteo.collina@gmail.com>

benchmark/http/_chunky_http_client.js

@@ -50,8 +50,6 @@ function main(conf) {
     }
   }
 
-  var success = 0;
-  var failure = 0;
   var min = 10;
   var size = 0;
   var mod = 317;
@@ -69,14 +67,12 @@ function main(conf) {
       if ((d.length === pattern.length && d === pattern) ||
           (d.length > pattern.length &&
            d.slice(0, pattern.length) === pattern)) {
-        success += 1;
         did = true;
       } else {
         pattern = 'HTTP/1.1 ';
         if ((d.length === pattern.length && d === pattern) ||
             (d.length > pattern.length &&
              d.slice(0, pattern.length) === pattern)) {
-          failure += 1;
           did = true;
         }
       }

benchmark/static_http_server.js

@@ -6,7 +6,6 @@ var port = 12346;
 var n = 700;
 var bytes = 1024 * 5;
 
-var requests = 0;
 var responses = 0;
 
 var body = 'C'.repeat(bytes);
@@ -37,6 +36,5 @@ server.listen(port, function() {
       });
     });
     req.id = i;
-    requests++;
   }
 });

doc/api/assert.md

@@ -13,6 +13,9 @@ additions or changes to any of the methods implemented and exposed by
 the module.
 
 ## assert(value[, message])
+<!-- YAML
+added: v0.5.9
+-->
 
 An alias of [`assert.ok()`][] .
 
@@ -30,6 +33,9 @@ assert(false, 'it\'s false');
 ```
 
 ## assert.deepEqual(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests for deep equality between the `actual` and `expected` parameters.
 Primitive values are compared with the equal comparison operator ( `==` ).
@@ -88,6 +94,9 @@ property set equal to the value of the `message` parameter. If the `message`
 parameter is undefined, a default error message is assigned.
 
 ## assert.deepStrictEqual(actual, expected[, message])
+<!-- YAML
+added: v1.2.0
+-->
 
 Generally identical to `assert.deepEqual()` with two exceptions. First,
 primitive values are compared using the strict equality operator ( `===` ).
@@ -109,6 +118,9 @@ property set equal to the value of the `message` parameter. If the `message`
 parameter is undefined, a default error message is assigned.
 
 ## assert.doesNotThrow(block[, error][, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Asserts that the function `block` does not throw an error. See
 [`assert.throws()`][] for more details.
@@ -161,6 +173,9 @@ assert.doesNotThrow(
 ```
 
 ## assert.equal(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests shallow, coercive equality between the `actual` and `expected` parameters
 using the equal comparison operator ( `==` ).
@@ -184,6 +199,9 @@ property set equal to the value of the `message` parameter. If the `message`
 parameter is undefined, a default error message is assigned.
 
 ## assert.fail(actual, expected, message, operator)
+<!-- YAML
+added: v0.1.21
+-->
 
 Throws an `AssertionError`. If `message` is falsy, the error message is set as
 the values of `actual` and `expected` separated by the provided `operator`.
@@ -200,6 +218,9 @@ assert.fail(1, 2, 'whoops', '>');
 ```
 
 ## assert.ifError(value)
+<!-- YAML
+added: v0.1.97
+-->
 
 Throws `value` if `value` is truthy. This is useful when testing the `error`
 argument in callbacks.
@@ -214,6 +235,9 @@ assert.ifError(new Error()); // Throws Error
 ```
 
 ## assert.notDeepEqual(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests for any deep inequality. Opposite of [`assert.deepEqual()`][].
 
@@ -255,6 +279,9 @@ property set equal to the value of the `message` parameter. If the `message`
 parameter is undefined, a default error message is assigned.
 
 ## assert.notDeepStrictEqual(actual, expected[, message])
+<!-- YAML
+added: v1.2.0
+-->
 
 Tests for deep strict inequality. Opposite of [`assert.deepStrictEqual()`][].
 
@@ -273,6 +300,9 @@ with a `message` property set equal to the value of the `message` parameter. If
 the `message` parameter is undefined, a default error message is assigned.
 
 ## assert.notEqual(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests shallow, coercive inequality with the not equal comparison operator
 ( `!=` ).
@@ -295,6 +325,9 @@ property set equal to the value of the `message` parameter. If the `message`
 parameter is undefined, a default error message is assigned.
 
 ## assert.notStrictEqual(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests strict inequality as determined by the strict not equal operator
 ( `!==` ).
@@ -317,6 +350,9 @@ If the values are strictly equal, an `AssertionError` is thrown with a
 `message` parameter is undefined, a default error message is assigned.
 
 ## assert.ok(value[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests if `value` is truthy. It is equivalent to
 `assert.equal(!!value, true, message)`.
@@ -339,6 +375,9 @@ assert.ok(false, 'it\'s false');
 ```
 
 ## assert.strictEqual(actual, expected[, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Tests strict equality as determined by the strict equality operator ( `===` ).
 
@@ -360,6 +399,9 @@ If the values are not strictly equal, an `AssertionError` is thrown with a
 `message` parameter is undefined, a default error message is assigned.
 
 ## assert.throws(block[, error][, message])
+<!-- YAML
+added: v0.1.21
+-->
 
 Expects the function `block` to throw an error.