Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for exec() known issue #7375

Closed
wants to merge 4 commits into from
Closed

test: add test for exec() known issue #7375

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad5b897
test: add test for exec() known issue
Trott Jun 22, 2016
d46fe32
squash: address nits, add test for stderr
Trott Jun 23, 2016
8485d17
squash: fix goofs
Trott Jun 23, 2016
8141cfa
squash: lint
Trott Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/known_issues/test-child-process-exec-stdout-data-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
// Refs: https://github.com/nodejs/node/issues/7342
const common = require('../common');
const assert = require('assert');
const exec = require('child_process').exec;

const keepAlive = setInterval(() => {}, 9999);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the child process keep the event loop open? Works for me locally without the timer.


const command = common.isWindows ? 'dir' : 'ls';
const e = exec(command);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you name this something like child? e seems like it would be an error.


e.stdout.on('data', function(data) {
assert.strictEqual(typeof data, 'string');
clearInterval(keepAlive);
});