Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify "Reviewed-By" iff "LGTM" #7183

Closed
wants to merge 1 commit into from
+1 −0
Closed

doc: clarify "Reviewed-By" iff "LGTM" #7183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ Landing a PR
* `Reviewed-By: human <email>`
* Easiest to use `git log` then do a search
* (`/Name` + `enter` (+ `n` as much as you need to) in vim)
* Only include collaborators who have commented "LGTM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CTC members should be included as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, certainly. All of the ctc members are also collaborators.

On Saturday, August 6, 2016, Yorkie Liu notifications@github.com wrote:

In doc/onboarding.md
#7183 (comment):

@@ -169,6 +169,7 @@ Landing a PR
* Reviewed-By: human <email>
* Easiest to use git log then do a search
* (/Name + enter (+ n as much as you need to) in vim)

  •  \* Only include collaborators who have commented "LGTM"

Does CTC members should be included as well?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node/pull/7183/files/f645b4c8da57891c7cf5b59987548e87e32479fb#r73786541,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAa2eXgC6ANpp1R5Da2oSUQu7NEtHcdmks5qdJUvgaJpZM4Ivauh
.

Copy link
Contributor

@yorkie yorkie Aug 6, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But currently the CTC members & collaborators are different lists in our README.md#Current Project Team Members, I thought that might have something confused to new comers :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point! I hadn't considered that. It might be worthwhile clarifying
that in the readme, I think :)

On Saturday, August 6, 2016, Yorkie Liu notifications@github.com wrote:

In doc/onboarding.md
#7183 (comment):

@@ -169,6 +169,7 @@ Landing a PR
* Reviewed-By: human <email>
* Easiest to use git log then do a search
* (/Name + enter (+ n as much as you need to) in vim)

  •  \* Only include collaborators who have commented "LGTM"

But currently the CTC members & collaborators are different lists in our README.md#Current
Project Team Members
https://github.com/nodejs/node#current-project-team-members, I thought
that might be have something confused to new comers :-)

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node/pull/7183/files/f645b4c8da57891c7cf5b59987548e87e32479fb#r73786660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAa2eQ5zIYoRSJARismkpHzT-BoE0xn2ks5qdJhUgaJpZM4Ivauh
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point! I hadn't considered that. It might be worthwhile clarifying
that in the readme, I think :)

@jasnell submitted a pull-request #7996 for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about expanding it as well?

  • Only include collaborators who have commented "LGTM" (Looks Good To Me)

* `PR-URL: <full-pr-url>`
* `git push upstream master`
* close the original PR with "Landed in `<commit hash>`".
Expand Down