Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-stdout-close-catch #6808

Merged
merged 1 commit into from
May 18, 2016
Merged

test: fix flaky test-stdout-close-catch #6808

merged 1 commit into from
May 18, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Make sure that catch-stdout-error has written data before the
destination process exits.

Fixes: #6791

Stress test on FreeBSD without this change fails: https://ci.nodejs.org/job/node-stress-single-test/727/

Stress test with this change succeeds: https://ci.nodejs.org/job/node-stress-single-test/731/

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 17, 2016
@santigimeno santigimeno mentioned this pull request May 17, 2016
Closed
@mscdex mscdex added stream Issues and PRs related to the stream subsystem. process Issues and PRs related to the process subsystem. labels May 17, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 17, 2016

LGTM

@santigimeno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/3372/

@jasnell
Copy link
Member

jasnell commented May 17, 2016

LGTM

1 similar comment
@r-52
Copy link
Contributor

r-52 commented May 17, 2016

LGTM

@santigimeno
test: fix flaky test-stdout-close-catch
89460f1 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: nodejs#6791
PR-URL: nodejs#6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@santigimeno
Copy link
Member Author

CI is green. Landing now.

@santigimeno santigimeno merged commit 89460f1 into nodejs:master May 18, 2016
@santigimeno santigimeno deleted the close_catch branch May 18, 2016 08:22
@santigimeno
Copy link
Member Author

Landed in 89460f1

@santigimeno
Copy link
Member Author

Thanks

Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@santigimeno @Fishrock123
test: fix flaky test-stdout-close-catch
e0116e3 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: #6791
PR-URL: #6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@santigimeno @rvagg
test: fix flaky test-stdout-close-catch
bae7adb 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: #6791
PR-URL: #6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
@santigimeno
test: fix flaky test-stdout-close-catch
a313fc7 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: #6791
PR-URL: #6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@santigimeno
test: fix flaky test-stdout-close-catch
1c4549a 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: #6791
PR-URL: #6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@santigimeno
test: fix flaky test-stdout-close-catch
5a04bfc 
Make sure that `catch-stdout-error` has written data before the
destination process exits.

Fixes: #6791
PR-URL: #6808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky parallel/test-stdout-close-catch on FreeBSD
7 participants
@santigimeno @cjihrig @jasnell @r-52 @mscdex @MylesBorins @nodejs-github-bot