Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.18.3 proposal #56699

Open
wants to merge 220 commits into
base: v20.x
Choose a base branch
from
Open

v20.18.3 proposal #56699

wants to merge 220 commits into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jan 22, 2025

2025-01-28, Version 20.18.3 'Iron' (LTS), @marco-ippolito

Notable Changes

  • [43abc6e287] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
  • [5bf61c5bec] - (SEMVER-MINOR) module: merge config with package_json_reader (Yagiz Nizipli) #50322
  • [eb5f757b30] - (SEMVER-MINOR) src: move package resolver to c++ (Yagiz Nizipli) #50322
  • [e954ef66d4] - (SEMVER-MINOR) deps: add simdjson (Yagiz Nizipli) #50322
  • [b04ab86d69] - doc: add LJHarb to collaborators (Jordan Harband) #56132
  • [97ffe8fa07] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  • [9246047aad] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681
  • [3ff8e8fb7a] - tools: fix root certificate updater (Richard Lau) #55681
  • [146aff4ac6] - doc: add jazelly to collaborators (Jason Zhang) #55531

Commits

  • [f985e1ab5a] - benchmark: add test-reporters (Aviv Keller) #55757
  • [bc3a047720] - benchmark: add test_runner/mock-fn (Aviv Keller) #55771
  • [1eee315153] - benchmark: add nodeTiming.uvmetricsinfo bench (RafaelGSS) #55614
  • [90a230d597] - benchmark: add --runs support to run.js (Rafael Gonzaga) #55158
  • [c65fc17867] - benchmark: adjust byte size for buffer-copy (Rafael Gonzaga) #55295
  • [b017225073] - buffer: document concat zero-fill (Duncan) #55562
  • [9e19a28318] - build: set DESTCPU correctly for 'make binary' on loongarch64 (吴小白) #56271
  • [7e000ec8ad] - build: fix missing fp16 dependency in d8 builds (Joyee Cheung) #56266
  • [3bcdfc83a1] - build: add major release action (Rafael Gonzaga) #56199
  • [5cd3433c36] - build: allow overriding clang usage (Shelley Vohr) #56016
  • [014aa89553] - build: remove defaults for create-release-proposal (Rafael Gonzaga) #56042
  • [e2198ba466] - build: set node_arch to target_cpu in GN (Shelley Vohr) #55967
  • [385902962f] - build: add create release proposal action (Rafael Gonzaga) #55690
  • [8ba8b2012d] - build: implement node_use_amaro flag in GN build (Cheng) #55798
  • [0e872cac81] - build: fix building with system icu 76 (Michael Cho) #55563
  • [bc78094cf1] - build: fix GN arg used in generate_config_gypi.py (Shelley Vohr) #55530
  • [c2165ebf9c] - build: fix GN build for cares/uv deps (Cheng) #55477
  • [b2ced1c85a] - build: fix uninstall script for AIX 7.1 (Cloorc) #55438
  • [4c75a92577] - build: tidy up cares.gyp (Richard Lau) #55445
  • [8a20f8ee75] - build: synchronize list of c-ares source files (Richard Lau) #55445
  • [282e625daf] - build: fix path concatenation (Mohammed Keyvanzadeh) #55387
  • [7517121c3d] - build: fix make errors that occur in Makefile (minkyu_kim) #55287
  • [b63437c7df] - build,win: enable pch for clang-cl (Stefan Stojanovic) #55249
  • [3c65c75ce5] - cli: add --heap-prof flag available to NODE_OPTIONS (Juan José) #54259
  • [b4cc52ea68] - crypto: ensure CryptoKey usages and algorithm are cached objects (Filip Skokan) #56108
  • [9246047aad] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681
  • [da76a9d34c] - deps: V8: cherry-pick 26fd1dfa9cd6 (Shu-yu Guo) #55961
  • [2f0158dcb6] - deps: V8: backport ae5a4db8ad86 (Shu-yu Guo) #55961
  • [e954ef66d4] - (SEMVER-MINOR) deps: add simdjson (Yagiz Nizipli) #50322
  • [7fcba0d010] - deps: update simdutf to 5.6.4 (Node.js GitHub Bot) #56255
  • [a1c85c3f0c] - deps: update c-ares to v1.34.4 (Node.js GitHub Bot) #56256
  • [c48b739ffb] - deps: upgrade npm to 10.9.2 (npm team) #56135
  • [0637370327] - deps: update zlib to 1.3.0.1-motley-82a5fec (Node.js GitHub Bot) #55980
  • [9cb8d65cbb] - deps: update corepack to 0.30.0 (Node.js GitHub Bot) #55977
  • [40abc3b9f0] - deps: update simdutf to 5.6.3 (Node.js GitHub Bot) #55973
  • [c88e2b55ef] - deps: upgrade npm to 10.9.1 (npm team) #55951
  • [795b2d6cf2] - deps: update zlib to 1.3.0.1-motley-7e2e4d7 (Node.js GitHub Bot) #54432
  • [07aad643d5] - deps: update simdutf to 5.6.2 (Node.js GitHub Bot) #55889
  • [69bd8716dc] - deps: update simdutf to 5.6.1 (Node.js GitHub Bot) #55850
  • [068080bcd9] - deps: update c-ares to v1.34.3 (Node.js GitHub Bot) #55803
  • [e1c4f1eecb] - deps: update icu to 76.1 (Node.js GitHub Bot) #55551
  • [5b77b21356] - deps: update acorn to 8.14.0 (Node.js GitHub Bot) #55699
  • [d4355d0054] - deps: update acorn to 8.13.0 (Node.js GitHub Bot) #55558
  • [c6112b3f77] - deps: update googletest to df1544b (Node.js GitHub Bot) #55465
  • [e7356d99df] - deps: update c-ares to v1.34.2 (Node.js GitHub Bot) #55463
  • [236abd8388] - deps: update ada to 2.9.1 (Node.js GitHub Bot) #54679
  • [acd9459978] - deps: update simdutf to 5.6.0 (Node.js GitHub Bot) #55379
  • [9fb3a7c22e] - deps: update c-ares to v1.34.1 (Node.js GitHub Bot) #55369
  • [2a7725aa04] - deps: upgrade npm to 10.9.0 (npm team) #55255
  • [5dfccb4417] - deps: upgrade npm to 10.8.3 (npm team) #54619
  • [91a6e3b5a7] - dgram: check udp buffer size to avoid fd leak (theanarkh) #56084
  • [3cf5bf5af9] - diagnostics_channel: fix unsubscribe during publish (simon-id) #55116
  • [e26c6e9117] - dns: stop using deprecated ares_query (Aviv Keller) #55430
  • [c8e045825b] - dns: honor the order option (Luigi Pinca) #55392
  • [595e71b8f4] - doc: add history entries for JSON modules stabilization (Antoine du Hamel) #55855
  • [bc445a0f02] - doc: fix color contrast issue in light mode (Rich Trott) #56272
  • [aeb48ca4ee] - doc: clarify util.aborted resource usage (Kunal Kumar) #55780
  • [0459c53a15] - doc: add esm examples to node:repl (Alfredo González) #55432
  • [a90bc0151a] - doc: add esm examples to node:readline (Alfredo González) #55335
  • [b44c2a0f8c] - doc: fix 'which' to 'that' and add commas (Selveter Senitro) #56216
  • [4b1a72195a] - doc: sea.getRawAsset(key) always returns an ArrayBuffer (沈鸿飞) #56206
  • [0462875cc2] - doc: update announce documentation for releases (Rafael Gonzaga) #56200
  • [f1549848ab] - doc: update blog link to /vulnerability (Rafael Gonzaga) #56198
  • [38dc5fccda] - doc: call out import.meta is only supported in ES modules (Anton Kastritskii) #56186
  • [30019a6e60] - doc: add ambassador message - benefits of Node.js (Michael Dawson) #56085
  • [0f1d256e20] - doc: fix incorrect link to style guide (Yuan-Ming Hsu) #56181
  • [ffe3da8b6c] - doc: fix c++ addon hello world sample (Edigleysson Silva (Edy)) #56172
  • [c7a58d93b9] - doc: update blog release-post link (Ruy Adorno) #56123
  • [4644b889e4] - doc: mention -a flag for the release script (Ruy Adorno) #56124
  • [b04ab86d69] - doc: add LJHarb to collaborators (Jordan Harband) #56132
  • [f384a9dfd4] - doc: add create-release-action to process (Rafael Gonzaga) #55993
  • [54a59a31b8] - doc: rename file to advocacy-ambassador-program.md (Tobias Nießen) #56046
  • [c9c8d07b72] - doc: remove unused import from sample code (Blended Bram) #55570
  • [97e901850d] - doc: add FAQ to releases section (Rafael Gonzaga) #55992
  • [957c72ccd9] - doc: move history entry to class description (Luigi Pinca) #55991
  • [1498396ecc] - doc: add history entry for textEncoder.encodeInto() (Luigi Pinca) #55990
  • [65b8c12e03] - doc: improve GN build documentation a bit (Shelley Vohr) #55968
  • [578dc2879b] - doc: remove confusing and outdated sentence (Luigi Pinca) #55988
  • [e8db10636e] - doc: add doc for PerformanceObserver.takeRecords() (skyclouds2001) #55786
  • [dc6ac81b58] - doc: add vetted courses to the ambassador benefits (Matteo Collina) #55934
  • [8bbf899e9c] - doc: doc how to add message for promotion (Michael Dawson) #55843
  • [e058fc8c4e] - doc: add esm example for zlib (Leonardo Peixoto) #55946
  • [07252b1153] - doc: document approach for building wasm in deps (Michael Dawson) #55940
  • [9c34ef4046] - doc: add esm examples to node:timers (Alfredo González) #55857
  • [0e0d61d9ba] - doc: include git node release --promote to steps (Rafael Gonzaga) #55835
  • [d795efc65d] - doc: add a note on console stream behavior (Gireesh Punathil) #55616
  • [dde582e657] - doc: add -S flag release preparation example (Antoine du Hamel) #55836
  • [a4445b1cda] - doc: clarify UV_THREADPOOL_SIZE env var usage (Preveen P) #55832
  • [5e3f2f13c0] - doc: add notable-change mention to sec release (Rafael Gonzaga) #55830
  • [47617f9f0d] - doc: fix history info for URL.prototype.toJSON (Antoine du Hamel) #55818
  • [e152f9cac4] - doc: correct max-semi-space-size statement (Joe Bowbeer) #55812
  • [c237b07f35] - doc: run license-builder (github-actions[bot]) #55813
  • [093fbab852] - doc: clarify triager role (Gireesh Punathil) #55775
  • [9ebf337d12] - doc: clarify removal of experimental API does not require a deprecation (Antoine du Hamel) #55746
  • [97ffe8fa07] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  • [b2b504fa8f] - doc: add esm example in path.md (Aviv Keller) #55745
  • [243267166c] - doc: consistent use of word child process (Gireesh Punathil) #55654
  • [ffb0d3c884] - doc: clarity to available addon options (Preveen P) #55715
  • [9c37065b92] - doc: update --max-semi-space-size description (Joe Bowbeer) #55495
  • [60805e41e8] - doc: add write flag when open file as the demo code's intention (robberfree) #54626
  • [93fddabff9] - doc: remove mention of ECDH-ES in crypto.diffieHellman (Filip Skokan) #55611
  • [fe04f6f1a7] - doc: improve c++ embedder API doc (Gireesh Punathil) #55597
  • [b2c290a890] - doc: capitalize "MIT License" (Aviv Keller) #55575
  • [327f16ffa2] - doc: add esm examples to node:string_decoder (Alfredo González) #55507
  • [146aff4ac6] - doc: add jazelly to collaborators (Jason Zhang) #55531
  • [3cc9469c21] - doc: changed the command used to verify SHASUMS256 (adriancuadrado) #55420
  • [c987bb91bd] - doc: add note about stdio streams in child_process (Ederin (Ed) Igharoro) #55322
  • [c94e747067] - doc: add isBigIntObject to documentation (leviscar) #55450
  • [ea557e996f] - doc: remove outdated remarks about highWaterMark in fs (Ian Kerins) #55462
  • [c954b858f4] - doc: move Danielle Adams key to old gpg keys (RafaelGSS) #55399
  • [266adc15a0] - doc: move Bryan English key to old gpg keys (RafaelGSS) #55399
  • [62b867d09c] - doc: move Beth Griggs keys to old gpg keys (RafaelGSS) #55399
  • [559184d26f] - doc: spell out condition restrictions (Jan Martin) #55187
  • [75359e0029] - doc: add missing return values in buffer docs (Karl Horky) #55273
  • [0e84b07572] - doc: fix ambasador markdown list (Rafael Gonzaga) #55361
  • [0035cd2d77] - doc: edit onboarding guide to clarify when mailmap addition is needed (Antoine du Hamel) #55334
  • [3f4d46580d] - doc: fix the return type of outgoingMessage.setHeaders() (Jimmy Leung) #55290
  • [43abc6e287] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
  • [95ca88f06e] - esm: add a fallback when importer in not a file (Antoine du Hamel) #55471
  • [c029311752] - esm: fix inconsistency with importAssertion in resolve hook (Wei Zhu) #55365
  • [78a942b784] - events: optimize EventTarget.addEventListener (Robert Nagy) #55312
  • [94f749a3c3] - fs: make mutating options in Promises readdir() not affect results (LiviaMedeiros) #56057
  • [69ec79d90f] - fs: lazily load ReadFileContext (Gürgün Dayıoğlu) #55998
  • [d764ff6308] - http2: support ALPNCallback option (ZYSzys) #56187
  • [d3e9300706] - http2: fix memory leak caused by premature listener removing (ywave620) #55966
  • [cbccc66b14] - http2: fix client async storage persistence (Orgad Shaneh) #55460
  • [3aa283afb1] - lib: add validation for options in compileFunction (Taejin Kim) #56023
  • [ded148419d] - lib: remove startsWith/endsWith primordials for char checks (Gürgün Dayıoğlu) #55407
  • [f7f5c36b49] - lib: test_runner#mock:timers respeced timeout_max behaviour (BadKey) #55375
  • [fa8212ecc9] - meta: bump github/codeql-action from 3.27.0 to 3.27.5 (dependabot[bot]) #56103
  • [cf6d31e505] - meta: bump actions/checkout from 4.1.7 to 4.2.2 (dependabot[bot]) #56102
  • [fc11ea8127] - meta: bump step-security/harden-runner from 2.10.1 to 2.10.2 (dependabot[bot]) #56101
  • [cc70ed3e87] - meta: bump actions/setup-node from 4.0.3 to 4.1.0 (dependabot[bot]) #56100
  • [c54dc8a63e] - meta: add releasers as CODEOWNERS to proposal action (Rafael Gonzaga) #56043
  • [8a6e4c65d9] - meta: bump actions/setup-python from 5.2.0 to 5.3.0 (dependabot[bot]) #55688
  • [00222305c3] - meta: bump actions/setup-node from 4.0.4 to 4.1.0 (dependabot[bot]) #55687
  • [b406b03753] - meta: bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2 (dependabot[bot]) #55686
  • [0789dec551] - meta: bump actions/upload-artifact from 4.4.0 to 4.4.3 (dependabot[bot]) #55685
  • [e9f251c23a] - meta: bump actions/cache from 4.0.2 to 4.1.2 (dependabot[bot]) #55684
  • [723479c924] - meta: bump actions/checkout from 4.2.0 to 4.2.2 (dependabot[bot]) #55683
  • [e614cb496d] - meta: bump github/codeql-action from 3.26.10 to 3.27.0 (dependabot[bot]) #55682
  • [2ba821703f] - meta: make review-wanted message minimal (Aviv Keller) #55607
  • [03c03d0a5c] - meta: show PR/issue title on review-wanted (Aviv Keller) #55606
  • [b62a284b3e] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #55381
  • [f09fbc7ccc] - meta: change color to blue notify review-wanted (Rafael Gonzaga) #55423
  • [9ec642d4ec] - meta: bump codecov/codecov-action from 4.5.0 to 4.6.0 (dependabot[bot]) #55222
  • [d64b138c8e] - meta: bump github/codeql-action from 3.26.6 to 3.26.10 (dependabot[bot]) #55221
  • [e75532d8b6] - meta: bump step-security/harden-runner from 2.9.1 to 2.10.1 (dependabot[bot]) #55220
  • [5bf61c5bec] - (SEMVER-MINOR) module: merge config with package_json_reader (Yagiz Nizipli) #50322
  • [c8bf8f9052] - module: prevent main thread exiting before esm worker ends (Shima Ryuhei) #56183
  • [6f10f39153] - node-api: allow napi_delete_reference in finalizers (Chengzhong Wu) #55620
  • [31839ca285] - report: fix network queries in getReport libuv with exclude-network (Adrien Foulon) #55602
  • [c953719863] - sea: only assert snapshot main function for main threads (Joyee Cheung) #56120
  • [eb5f757b30] - (SEMVER-MINOR) src: move package resolver to c++ (Yagiz Nizipli) #50322
  • [5c90efd3e5] - src: fix outdated js2c.cc references (Chengzhong Wu) #56133
  • [8634171a26] - src: fix kill signal on Windows (Hüseyin Açacak) #55514
  • [f41aa5b820] - src: improve node:os userInfo performance (Yagiz Nizipli) #55719
  • [3945b8b725] - src: fix dns crash when failed to create NodeAresTask (theanarkh) #55521
  • [56d743181d] - src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT (Charles Kerr) #55581
  • [c910ec8666] - src: remove icu based ToASCII and ToUnicode (Yagiz Nizipli) #55156
  • [af25971f71] - src: fix winapi_strerror error string (Hüseyin Açacak) #55207
  • [f7c4affdc4] - src,lib: optimize nodeTiming.uvMetricsInfo (RafaelGSS) #55614
  • [86143af404] - stream: propagate AbortSignal reason (Marvin ROGER) #55473
  • [5c49e7df9f] - test: remove exludes for sea tests on PPC (Michael Dawson) #56217
  • [d50c56afe7] - test: move localizationd data from test-icu-env to external file (Livia Medeiros) #55618
  • [1cc7032d45] - test: remove hasOpenSSL3x utils (Antoine du Hamel) #56164
  • [d803f2daa5] - test: remove test-fs-utimes flaky designation (Luigi Pinca) #56052
  • [06943fc2ba] - test: move test-worker-arraybuffer-zerofill to parallel (Luigi Pinca) #56053
  • [016871b68c] - test: make HTTP/1.0 connection test more robust (Arne Keller) #55959
  • [c7af5c62f5] - test: convert readdir test to use test runner (Thomas Chetwin) #55750
  • [8704732ec3] - test: make x509 crypto tests work with BoringSSL (Shelley Vohr) #55927
  • [0ae1c39579] - test: fix determining lower priority (Livia Medeiros) #55908
  • [e894395c13] - test: increase coverage of pathToFileURL (Antoine du Hamel) #55493
  • [98e0289a1d] - test: improve test coverage for child process message sending (Juan José) #55710
  • [e00156ed15] - test: ensure that test priority is not higher than current priority (Livia Medeiros) #55739
  • [fbb861cd13] - test: add buffer to fs_permission tests (Rafael Gonzaga) #55734
  • [aceb011039] - test: improve test coverage for ServerResponse (Juan José) #55711
  • [e03257e78a] - test: ignore unrelated events in FW watch tests (Carlos Espa) #55605
  • [87ff134522] - test: refactor some esm tests (Antoine du Hamel) #55472
  • [3fc15341b5] - test: split up test-runner-mock-timers test (Julian Gassner) #55506
  • [f95cea7f57] - test: avoid apply() calls with large amount of elements (Livia Medeiros) #55501
  • [8d58435908] - test: increase test coverage for http.OutgoingMessage.appendHeader() (Juan José) #55467
  • [31aaa94e64] - test: fix addons and node-api test assumptions (Antoine du Hamel) #55441
  • [5cb2a2e6f2] - test: deflake test-cluster-shared-handle-bind-privileged-port (Aviv Keller) #55378
  • [af204349db] - test: remove duplicate tests (Luigi Pinca) #55393
  • [11eacb1eab] - test: update test_util.cc for coverage (minkyu_kim) #55291
  • [923154b63c] - test,crypto: make crypto tests work with BoringSSL (Shelley Vohr) #55491
  • [aa07bb9d5d] - test_runner: simplify hook running logic (Colin Ihrig) #55963
  • [ab1e7c7a3f] - test_runner: error on mocking an already mocked date (Aviv Keller) #55858
  • [76ae9d714d] - test_runner: add support for scheduler.wait on mock timers (Erick Wendel) #55244
  • [f6f89de0d5] - tools: update github_reporter to 1.7.2 (Node.js GitHub Bot) #56205
  • [bec83ffc04] - tools: add REPLACEME check to workflow (Mert Can Altin) #56251
  • [caf09566cb] - tools: use github.actor instead of bot username for release proposals (Antoine du Hamel) #56232
  • [535aa8fde5] - tools: fix release proposal linter to support more than 1 folk preparing (Antoine du Hamel) #56203
  • [bfb1e51ddb] - tools: use commit title as PR title when creating release proposal (Antoine du Hamel) #56165
  • [548c3035f0] - tools: improve release proposal PR opening (Antoine du Hamel) #56161
  • [ee89fd4ff6] - tools: update create-release-proposal workflow (Antoine du Hamel) #56054
  • [19e38c40eb] - tools: fix update-undici script (Michaël Zasso) #56069
  • [ae4d27bb15] - tools: allow dispatch of tools.yml from forks (Antoine du Hamel) #56008
  • [175fcafc33] - tools: fix nghttp3 updater script (Antoine du Hamel) #56007
  • [63fa8b1863] - tools: filter release keys to reduce interactivity (Antoine du Hamel) #55950
  • [512d95b081] - tools: update WPT updater (Antoine du Hamel) #56003
  • [c6dec5d178] - tools: add WPT updater for specific subsystems (Mert Can Altin) #54460
  • [bfbf5bab89] - tools: use tokenless Codecov uploads (Michaël Zasso) #55943
  • [a8f2e34ca3] - tools: add linter for release commit proposals (Antoine du Hamel) #55923
  • [155e417cab] - tools: fix exclude labels for commit-queue (Richard Lau) #55809
  • [6173cff81e] - tools: make commit-queue check blocked label (Marco Ippolito) #55781
  • [0751a70788] - tools: fix c-ares updater script for Node.js 18 (Richard Lau) #55717
  • [3ff8e8fb7a] - tools: fix root certificate updater (Richard Lau) #55681
  • [0d791587cb] - tools: compact jq output in daily-wpt-fyi.yml action (Filip Skokan) #55695
  • [da379a8295] - tools: run daily WPT.fyi report on all supported releases (Filip Skokan) #55619
  • [0fb5d709cd] - tools: update lint-md-dependencies (Node.js GitHub Bot) #55470
  • [0077c10f0c] - tools: add script to synch c-ares source lists (Richard Lau) #55445
  • [32f0e94117] - url: handle "unsafe" characters properly in pathToFileURL (Antoine du Hamel) #54545
  • [ad7bc88383] - util: fix Latin1 decoding to return string output (Mert Can Altin) #56222
  • [310c4efe80] - util: do not rely on mutable Object and Function' constructor prop (Antoine du Hamel) #56188
  • [2b6bdee749] - util: add fast path for Latin1 decoding (Mert Can Altin) #55275
  • [afa44fbcde] - util: do not catch on circular @@toStringTag errors (Aviv Keller) #55544
  • [3e05ed7e8d] - worker: fix crash when a worker joins after exit (Stephen Belanger) #56191

npm-cli-bot and others added 30 commits January 22, 2025 09:43
PR-URL: #54619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Fixes: #55208
PR-URL: #55249
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The actual implementation returns `outgoingMessage` itself, but not
exactly `http.ServerResponse`.

Refs: https://github.com/nodejs/node/blob/20d8b85d3493bec944de541a896e0165dd356345/lib/_http_outgoing.js#L712-L751
PR-URL: #55290
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
PR-URL: #55334
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.1 to 2.10.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@5c7944e...91182cc)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4dd1613...e2b3eaf)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #55222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55361
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #55273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
fix make errors that occur in
 coverage-clean case and coverage-test in Makefile

PR-URL: #55287
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
update test_util.cc for code coverage src/util-inl.h:PopFront()

PR-URL: #55291
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55312
Fixes: #55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #55116
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
PR-URL: #55295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Fixes: #23191
PR-URL: #55207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55375
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
PR-URL: #55379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
As the documentation states, the `context.importAssertion` should be
still supported and emit a warning. This is true for the `load` hook,
but not correct for context of the `resolve` hook.

This commit fixes the inconsistency.

PR-URL: #55365
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This adds support for nodetimers.promises.scheduler.wait on Mocktimers

Refs: #55244
PR-URL: #55244
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #55187
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
- The `Path` class does not support concatenation with the `+`
operator, so use the `/` operator instead.
- When concatenating paths, if the operand is an absolute path the
previous path is ignored, so change `/include` to `include`.

PR-URL: #55387
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: #55391
PR-URL: #55392
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
`test/parallel/test-dns-default-verbatim-false.js` is a duplicate of
`test/parallel/test-dns-default-order-ipv4.js` and
`test/parallel/test-dns-default-verbatim-true.js` is a duplicate of
`test/parallel/test-dns-default-order-verbatim.js`.

PR-URL: #55393
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
The current colour seems something went wrong when in fact
it's just someone asking for a review.

PR-URL: #55423
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Refs: nodejs/Release#1042
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/Release#1040
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55158
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
nicolo-ribaudo and others added 2 commits January 22, 2025 16:53
The two proposals reached stage 4 at the October 2024 meeting.

PR-URL: #55333
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Backport-PR-URL: #55961
PR-URL: #55855
Refs: #55333
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Backport-PR-URL: #55961
marco-ippolito added a commit that referenced this pull request Jan 22, 2025
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
module:
  * (SEMVER-MINOR) merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * (SEMVER-MINOR) move package resolver to c++ (Yagiz Nizipli) #50322
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: #56699
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * add LJHarb to collaborators (Jordan Harband) #56132
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
module:
  * (SEMVER-MINOR) merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * (SEMVER-MINOR) move package resolver to c++ (Yagiz Nizipli) #50322
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: #56699
@marco-ippolito marco-ippolito added v8 engine Issues and PRs related to the V8 dependency. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2025

Can we include #56721? It's a doc-only change, fixing incomplete documentation just got out in the security release.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jan 23, 2025

Can we include #56721? It's a doc-only change, fixing incomplete documentation just got out in the security release.

sure, if CI is green

On another topic, I see some failures:

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_withoutintl_x64/48511/consoleFull

23:32:14 not ok 1772 parallel/test-icu-env
23:32:14   ---
23:32:14   duration_ms: 112.59300
23:32:15   severity: fail
23:32:15   exitcode: 1
23:32:15   stack: |-
23:32:15     /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-icu-env.js:28
23:32:15       const [ latestVersion ] = globSync('test/fixtures/icu/localizationData-*.json')
23:32:15                                 ^
23:32:15     
23:32:15     TypeError: globSync is not a function
23:32:15         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-icu-env.js:28:29)
23:32:15         at Module._compile (node:internal/modules/cjs/loader:1468:14)
23:32:15         at Module._extensions..js (node:internal/modules/cjs/loader:1547:10)
23:32:15         at Module.load (node:internal/modules/cjs/loader:1287:32)
23:32:15         at Module._load (node:internal/modules/cjs/loader:1103:12)
23:32:15         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:180:12)
23:32:15         at node:internal/main/run_main_module:28:49
23:32:15     
23:32:15     Node.js v20.18.3

This is caused by a364ec1, which I will drop for the proposal

@nodejs/platform-smartos this is the smartos failure:

03:13:42 not ok 177 parallel/test-buffer-tostring-range
03:13:42   ---
03:13:43   duration_ms: 5550.52900
03:13:43   severity: fail
03:13:43   exitcode: 1
03:13:43   stack: |-
03:13:43     node:internal/buffer:961
03:13:43         super(bufferOrLength, byteOffset, length);
03:13:43         ^
03:13:43     
03:13:43     RangeError: Array buffer allocation failed
03:13:43         at new ArrayBuffer (<anonymous>)
03:13:43         at new Uint8Array (<anonymous>)
03:13:43         at new FastBuffer (node:internal/buffer:961:5)
03:13:43         at Function.alloc (node:buffer:395:10)
03:13:43         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos23-x64/test/parallel/test-buffer-tostring-range.js:107:28)
03:13:43         at Module._compile (node:internal/modules/cjs/loader:1468:14)
03:13:43         at Module._extensions..js (node:internal/modules/cjs/loader:1547:10)
03:13:43         at Module.load (node:internal/modules/cjs/loader:1287:32)
03:13:43         at Module._load (node:internal/modules/cjs/loader:1103:12)
03:13:43         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:180:12)
03:13:43     
03:13:43     Node.js v20.18.3
03:13:43   ...

@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2025

For test-icu-env failure, I suggest we drop d50c56afe7 from this proposal

@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2025

  • [5bf61c5bec] - (SEMVER-MINOR) module: merge config with package_json_reader (Yagiz Nizipli) #50322
  • [eb5f757b30] - (SEMVER-MINOR) src: move package resolver to c++ (Yagiz Nizipli) #50322
  • [e954ef66d4] - (SEMVER-MINOR) deps: add simdjson (Yagiz Nizipli) #50322

Doesn't that mean the version should be v20.19.0? Otherwise, I think we need to drop those from this release for semver compliance sake

@marco-ippolito
Copy link
Member Author

  • [5bf61c5bec] - (SEMVER-MINOR) module: merge config with package_json_reader (Yagiz Nizipli) #50322
  • [eb5f757b30] - (SEMVER-MINOR) src: move package resolver to c++ (Yagiz Nizipli) #50322
  • [e954ef66d4] - (SEMVER-MINOR) deps: add simdjson (Yagiz Nizipli) #50322

Doesn't that mean the version should be v20.19.0? Otherwise, I think we need to drop those from this release for semver compliance sake

those are backports needed for backporting require(esm), it adds a dependency but its not exposed #56590 (comment)

@nodejs/releasers should we bump a minor?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jan 23, 2025

created a PR to unblock the error on smartos: #56727
Closed the PR by mistake 😭

@richardlau
Copy link
Member

  • [5bf61c5bec] - (SEMVER-MINOR) module: merge config with package_json_reader (Yagiz Nizipli) #50322
  • [eb5f757b30] - (SEMVER-MINOR) src: move package resolver to c++ (Yagiz Nizipli) #50322
  • [e954ef66d4] - (SEMVER-MINOR) deps: add simdjson (Yagiz Nizipli) #50322

Doesn't that mean the version should be v20.19.0? Otherwise, I think we need to drop those from this release for semver compliance sake

those are backports needed for backporting require(esm), it adds a dependency but its not exposed #56590 (comment)

@nodejs/releasers should we bump a minor?

Yes, we should if we're including require(esm).

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (7017811) to head (ec8d195).
Report is 7 commits behind head on v20.x.

Additional details and impacted files
@@           Coverage Diff            @@
##            v20.x   #56699    +/-   ##
========================================
  Coverage   93.53%   93.54%            
========================================
  Files         314      313     -1     
  Lines      121227   121331   +104     
  Branches    23747    23790    +43     
========================================
+ Hits       113387   113495   +108     
+ Misses       7618     7605    -13     
- Partials      222      231     +9     

see 35 files with indirect coverage changes

@richardlau
Copy link
Member

[e1c4f1eecb] - deps: update icu to 76.1 (Node.js GitHub Bot) #55551

Not sure if we should hold off updating ICU in light of #56737.

@marco-ippolito
Copy link
Member Author

[e1c4f1eecb] - deps: update icu to 76.1 (Node.js GitHub Bot) #55551

Not sure if we should hold off updating ICU in light of #56737.

I'll drop it from the proposal

@richardlau
Copy link
Member

richardlau commented Jan 24, 2025

Also FWIW from today's v20.x-staging daily CI, osx1015 is failing due to the npm update since we haven't resolved nodejs/nodejs-dependency-vuln-assessments#193 re. the node-gyp update it contains.

@marco-ippolito
Copy link
Member Author

Also FWIW from today's v20.x-staging daily CI, osx1015 is failing due to the npm update since we haven't resolved nodejs/nodejs-dependency-vuln-assessments#193 re. the node-gyp update it contains.

Should we drop npm update? And mark it dont-land-on-v20x? Im waiting for the smartos fix to get a green ci and update this proposal

@aduh95
Copy link
Contributor

aduh95 commented Jan 24, 2025

Yes let's drop it – we're never going to get a green CI with it anytime soon, and we need a green CI to land the SmartOS flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. release Issues and PRs related to Node.js releases. v8 engine Issues and PRs related to the V8 dependency. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.