quic: fixup errant LocalVector usage #56564
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Jan 11, 2025
| @@ -2728,7 +2728,7 @@ void Session::EmitVersionNegotiation(const ngtcp2_pkt_hd& hd, | |||
|
|
|||
| LocalVector<Value> versions(env()->isolate(), nsv); | |||
| for (size_t n = 0; n < nsv; n++) { | |||
| versions.push_back(Integer::NewFromUnsigned(env()->isolate(), sv[n])); | |||
| versions[0] = Integer::NewFromUnsigned(env()->isolate(), sv[n]); | |||
There was a problem hiding this comment.
Suggested change
| versions[0] = Integer::NewFromUnsigned(env()->isolate(), sv[n]); | |
| versions[n] = Integer::NewFromUnsigned(env()->isolate(), sv[n]); |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56564 +/- ##
==========================================
+ Coverage 89.16% 89.18% +0.01%
==========================================
Files 661 662 +1
Lines 191421 191759 +338
Branches 36845 36902 +57
==========================================
+ Hits 170673 171011 +338
+ Misses 13615 13614 -1
- Partials 7133 7134 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.