Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add validateStream to styleText bench #56556

Merged
merged 2 commits into from
Jan 12, 2025
Merged

benchmark: add validateStream to styleText bench #56556

merged 2 commits into from
Jan 12, 2025

Conversation

RafaelGSS
Copy link
Member

I noted that when we don't validate the stream it's reasonably faster than when it does.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Jan 10, 2025
@RafaelGSS RafaelGSS force-pushed the add-validateStream-bench branch from f799e44 to ac685f8 Compare January 10, 2025 20:46
mcollina
mcollina approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS force-pushed the add-validateStream-bench branch from ac685f8 to 6580f3f Compare January 11, 2025 14:19
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 99099d6 into nodejs:main Jan 12, 2025
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 99099d6

targos pushed a commit that referenced this pull request Jan 13, 2025
@RafaelGSS @targos
benchmark: add validateStream to styleText bench
47b7495 
PR-URL: #56556
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@RafaelGSS @Ceres6
benchmark: add validateStream to styleText bench
ec65d56 
PR-URL: nodejs#56556
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @nodejs-github-bot @mcollina @jasnell @lpinca