Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor fs readdir buffer with test runner #55748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: refactor fs readdir buffer with test runner #55748

wants to merge 1 commit into from
+16 −9

Conversation

sercanpaspal
Copy link

@sercanpaspal sercanpaspal commented Nov 6, 2024 •
edited
Loading

Refactor of test/parallel/test-fs-readdir-buffer.js with node test runner.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2024
@sercanpaspal sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from a0d780f to 684e6b9 Compare November 6, 2024 15:21
@bengl bengl added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63458/

@sercanpaspal sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch 2 times, most recently from ab09006 to 843bb2d Compare November 6, 2024 15:36
@pmarchini
Copy link
Member

Hey @sercanpaspal, js linting is failing.
You can fix it running make lint-js-fix

image

@sercanpaspal sercanpaspal force-pushed the test-refactor-fs-readdir-buffer-with-test-runner branch from 843bb2d to 33c87c4 Compare November 6, 2024 15:48
@sercanpaspal
Copy link
Author

Hi @pmarchini , thank you for your help & information.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (1aa7135) to head (33c87c4).
Report is 103 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55748      +/-   ##
==========================================
- Coverage   88.40%   87.91%   -0.49%     
==========================================
  Files         654      654              
  Lines      187747   187747              
  Branches    36127    35820     -307     
==========================================
- Hits       165972   165062     -910     
- Misses      15009    15888     +879     
- Partials     6766     6797      +31

see 99 files with indirect coverage changes

---- 🚨 Try these New Features:

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63676/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sercanpaspal @nodejs-github-bot @pmarchini @jasnell @bengl