http, readline: replace sort with toSorted #53623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
anonrig
approved these changes
Jun 28, 2024
richardlau
approved these changes
Jun 28, 2024
pimterry
approved these changes
Jun 28, 2024
lpinca
approved these changes
Jun 28, 2024
MoLow
approved these changes
Jun 30, 2024
trivikr
approved these changes
Jun 30, 2024
jasnell
approved these changes
Jul 1, 2024
|
@benjamingr this now conflicts |
|
This failed in the Jenkins CI because of the merge commit. |
|
Sorry, new job, new gitconfig, pushing a fix |
8431b61 to
abd2eab
Compare
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9862771244 |
Commit Queue failed- Loading data for nodejs/node/pull/53623 ✔ Done loading data for nodejs/node/pull/53623 ----------------------------------- PR info ------------------------------------ Title http, readline: replace sort with toSorted (#53623) Author Benjamin Gruenbaum <inglor@gmail.com> (@benjamingr) Branch benjamingr:replace-with-tosorted -> nodejs:main Labels http, readline, needs-ci, typings, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - http, readline: replace sort with toSorted Committers 1 - Benjamin Gruenbaum <benji@eon.io> PR-URL: https://github.com/nodejs/node/pull/53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - http, readline: replace sort with toSorted ℹ This PR was created on Fri, 28 Jun 2024 12:38:56 GMT ✔ Approvals: 8 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148102817 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148120155 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148213278 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53623#pullrequestreview-2148271807 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2149963447 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2149970876 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53623#pullrequestreview-2150175739 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53623#pullrequestreview-2151991049 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-09T23:43:34Z: https://ci.nodejs.org/job/node-test-pull-request/60208/ - Querying data for job/node-test-pull-request/60208/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9877917825 |
richardlau
approved these changes
Jul 10, 2024
|
Landed in fd21dd4 |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53623 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor chore, Richard's set.difference PR reminded me our V8 is new enough to support toSorted and we can avoid
.slice().sort(...).