Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update markdown footnote formatting for linting #52570

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 17, 2024

The new version of remark-lint-final-definition flags two things in our docs. These changes are needed before we land the updated package in our markdown linter.

Refs: nodejs/remark-preset-lint-node#511

The new version of remark-lint-final-definition flags two things in our
docs. These changes are needed before we land the updated package in our
markdown linter.

Refs: nodejs/remark-preset-lint-node#511
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 17, 2024
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 17, 2024
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Apr 17, 2024

Ugh, this is probably a bug in the linter. I'll put this in draft mode until that gets sorted out.

@Trott Trott marked this pull request as draft April 17, 2024 17:51
@Trott
Copy link
Member Author

Trott commented Apr 17, 2024

Bug in linter fixed in remark-lint-final-definition@4.0.1. This should now be unnecessary.

@Trott Trott closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants