Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce flakiness of test-runner-output #51952

Merged
merged 2 commits into from
Mar 5, 2024
Merged

test: reduce flakiness of test-runner-output #51952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e22eb
test: reduce flakiness of `test-runner-output`
aduh95 Mar 3, 2024
b5c4b00
Apply suggestions from code review
aduh95 Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/fixtures/test-runner/output/describe_it.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,18 @@ describe('describe async throw fails', async () => {
describe('timeouts', () => {
it('timed out async test', { timeout: 5 }, async () => {
return new Promise((resolve) => {
setTimeout(resolve, 100);
setTimeout(() => {
// Empty timer so the process doesn't exit before the timeout triggers.
}, 5);
setTimeout(resolve, 30_000_000).unref();
});
});

it('timed out callback test', { timeout: 5 }, (t, done) => {
setTimeout(done, 100);
setTimeout(() => {
// Empty timer so the process doesn't exit before the timeout triggers.
}, 5);
setTimeout(done, 30_000_000).unref();
});


Expand Down