tools: update comment in update-uncidi.sh and acorn_version.h
#50175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Oct 13, 2023
richardlau
approved these changes
Oct 13, 2023
Commit Queue failed- Loading data for nodejs/node/pull/50175 ✔ Done loading data for nodejs/node/pull/50175 ----------------------------------- PR info ------------------------------------ Title tools: update comment in `update-uncidi.sh` and `acorn_version.h` (#50175) Author Jungku Lee (@pluris) Branch pluris:fix/update_comment_autogen -> nodejs:main Labels c++, tools, author ready Commits 1 - tools: update comment in `update-uncidi.sh` and `acorn_version.h` Committers 1 - pluris PR-URL: https://github.com/nodejs/node/pull/50175 Fixes: https://github.com/nodejs/node/issues/50159 Refs: https://github.com/nodejs/node/pull/50165 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50175 Fixes: https://github.com/nodejs/node/issues/50159 Refs: https://github.com/nodejs/node/pull/50165 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 13 Oct 2023 14:32:33 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50175#pullrequestreview-1676655761 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50175#pullrequestreview-1676658798 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6524713736 |
RafaelGSS
approved these changes
Oct 15, 2023
|
Landed in 50edbdf |
kumarrishav
pushed a commit
to kumarrishav/node
that referenced
this pull request
Oct 16, 2023
PR-URL: nodejs#50175 Fixes: nodejs#50159 Refs: nodejs#50165 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50175 Fixes: nodejs#50159 Refs: nodejs#50165 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added it because there was code that wasn't modified in the previous PR.
Fixes: #50159
Refs: #50165