Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-runner-watch-mode as flaky #49627

Merged
merged 1 commit into from
Sep 14, 2023
Merged

test: mark test-runner-watch-mode as flaky #49627

merged 1 commit into from
Sep 14, 2023

Conversation

joyeecheung
Copy link
Member

Refs: #49605

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53913/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@joyeecheung
Copy link
Member Author

Actually it's flaky on both Linux and Windows. nodejs/reliability#663 Added windows to the condition.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53914/

@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53923/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53926/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 13, 2023
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Open
15 tasks
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit b289c6d into nodejs:main Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b289c6d

This was referenced Sep 15, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
test: mark test-runner-watch-mode as flaky
ab3afb3 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@joyeecheung @alexfernandez
test: mark test-runner-watch-mode as flaky
e5619f9 
PR-URL: nodejs#49627
Refs: nodejs#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@joyeecheung @targos
test: mark test-runner-watch-mode as flaky
5df2352 
PR-URL: #49627
Refs: #49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: mark test-runner-watch-mode as flaky
6305d66 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: mark test-runner-watch-mode as flaky
2201bcf 
PR-URL: nodejs/node#49627
Refs: nodejs/node#49605
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@anonrig anonrig anonrig approved these changes

@watilde watilde watilde approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @nodejs-github-bot @watilde @anonrig @LiviaMedeiros @debadree25