Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix callback_queue.h missing header #48733

Merged
merged 1 commit into from
Aug 10, 2023
Merged

src: fix callback_queue.h missing header #48733

merged 1 commit into from
Aug 10, 2023

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 11, 2023 •
edited
Loading

std::unique_ptr is in the memory header, this PR adds the header inclusion

image

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 12, 2023

I don't think the failing test is related to this PR

@aduh95 aduh95 requested a review from addaleax July 15, 2023 17:45
@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53029/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 54e4f1f into nodejs:main Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 54e4f1f

martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@CGQAQ @martenrichter
src: fix callback_queue.h missing header
c5c7fe3 
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: fix callback_queue.h missing header
d9019a1 
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: fix callback_queue.h missing header
f68bb9b 
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@CGQAQ @RafaelGSS
src: fix callback_queue.h missing header
2e8380d 
PR-URL: #48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@CGQAQ @RafaelGSS
src: fix callback_queue.h missing header
4060f24 
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@CGQAQ @rluvaton
src: fix callback_queue.h missing header
a366422 
PR-URL: nodejs#48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@CGQAQ CGQAQ deleted the src-fix-callback_queue-missing-header branch August 16, 2023 08:20
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@CGQAQ @RafaelGSS
src: fix callback_queue.h missing header
9d13503 
PR-URL: #48733
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeyeon daeyeon daeyeon approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CGQAQ @nodejs-github-bot @daeyeon @aduh95