-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: support sync 'overlapped' stdio option #48479
Open
bnoordhuis
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
bnoordhuis:fix48476
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
child_process
Issues and PRs related to the child_process subsystem.
needs-ci
PRs that need a full CI run.
labels
Jun 17, 2023
juanarbol
approved these changes
Jun 17, 2023
anonrig
approved these changes
Jun 18, 2023
bnoordhuis
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
needs-ci
PRs that need a full CI run.
labels
Jun 18, 2023
github-actions
bot
added
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jun 18, 2023
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5305271123 |
bnoordhuis
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
labels
Jun 19, 2023
jasnell
approved these changes
Jun 20, 2023
lpinca
approved these changes
Jun 20, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 20, 2023
30 tasks
Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync(). Fixes: nodejs#48476 Refs: nodejs#29412
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 11, 2024
Related CI failures:
|
aduh95
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
child_process
Issues and PRs related to the child_process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync().
Fixes: #48476
Refs: #29412