Code

48198 node api external strings#48339

Code

Closed

gabrielschulhof wants to merge 31 commits intonodejs:mainnodejs/node:mainfrom gabrielschulhof:48198-node-api-external-stringsgabrielschulhof/node:48198-node-api-external-stringsCopy head branch name to clipboard

+713-176

Commits

Commits on Jun 7, 2023

• node-api: unify string creation

  gabrielschulhof

  committed
  bd8045b

  Copy full SHA for bd8045b

• node-api: add string creation benchmark

  gabrielschulhof

  committed
  50a2109

  Copy full SHA for 50a2109

• node-api: implement external strings

  gabrielschulhof

  committed
  1364872

  Copy full SHA for 1364872

• add test

  gabrielschulhof

  committed
  a9e24b9

  Copy full SHA for a9e24b9

• rename to node_api_*

  gabrielschulhof

  committed
  e1127d1

  Copy full SHA for e1127d1

• put back build type

  gabrielschulhof

  committed
  953304c

  Copy full SHA for 953304c

• make linter work

  gabrielschulhof

  committed
  09f7cdf

  Copy full SHA for 09f7cdf

• rename as requested

  gabrielschulhof

  committed
  902cb33

  Copy full SHA for 902cb33

• use std::basic_string_view to calc length in case of NAPI_AUTO_LENGTH

  gabrielschulhof

  committed
  754864e

  Copy full SHA for 754864e

• test for auto-length

  gabrielschulhof

  committed
  95a9971

  Copy full SHA for 95a9971

• format

  gabrielschulhof

  committed
  b4f383b

  Copy full SHA for b4f383b

• correct length

  gabrielschulhof

  committed
  05317ac

  Copy full SHA for 05317ac

• doc

  gabrielschulhof

  committed
  20ab0fb

  Copy full SHA for 20ab0fb

Commits on Jun 8, 2023

• use right length indicator

  gabrielschulhof

  committed
  ca4c08c

  Copy full SHA for ca4c08c

• final adjustment

  gabrielschulhof

  committed
  5de34d4

  Copy full SHA for 5de34d4

• Apply suggestions from code review

  gabrielschulhof

  authored
  64f2498

  Copy full SHA for 64f2498

• Apply suggestions from code review

  Show description for cb9d95a
  

  gabrielschulhof

  and

  daeyeon

  authored
  cb9d95a

  Copy full SHA for cb9d95a

Commits on Jun 9, 2023

• remove utf8

  gabrielschulhof

  committed
  ed83494

  Copy full SHA for ed83494

Commits on Jun 10, 2023

• handle the case where we copy the string

  gabrielschulhof

  committed
  e063901

  Copy full SHA for e063901

• implement the non-copying case

  gabrielschulhof

  committed
  4ff5e53

  Copy full SHA for 4ff5e53

Commits on Jun 11, 2023

• Unify the two external cases

  gabrielschulhof

  committed
  402c93e

  Copy full SHA for 402c93e

• factor out tracking

  gabrielschulhof

  committed
  32a5600

  Copy full SHA for 32a5600

• document

  gabrielschulhof

  committed
  0b72009

  Copy full SHA for 0b72009

• debug ctor dtor

  gabrielschulhof

  committed
  50dfa5d

  Copy full SHA for 50dfa5d

• typo

  gabrielschulhof

  committed
  3a96b04

  Copy full SHA for 3a96b04

• Apply suggestions from code review

  gabrielschulhof

  authored
  caccb8e

  Copy full SHA for caccb8e

• Apply suggestions from code review

  gabrielschulhof

  authored
  5c11c81

  Copy full SHA for 5c11c81

Commits on Jun 12, 2023

• use common distructor

  gabrielschulhof

  committed
  b651fca

  Copy full SHA for b651fca

• format

  gabrielschulhof

  committed
  668fd4d

  Copy full SHA for 668fd4d

• Apply suggestions from code review

  Show description for c721439
  

  gabrielschulhof

  and

  daeyeon

  authored
  c721439

  Copy full SHA for c721439

• md lint

  gabrielschulhof

  committed
  7f67a2f

  Copy full SHA for 7f67a2f