Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,fs: update description of fs.stat() method #47654

Merged
merged 5 commits into from
Apr 23, 2023
Merged

doc,fs: update description of fs.stat() method #47654

merged 5 commits into from
Apr 23, 2023

Conversation

mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Apr 21, 2023 •
edited
Loading

Hi as mentioned in the talk, fs.stat watches the symlinks, while fs.lstat looks at the symlinks themselves. For this reason, it is recommended to use fs.lstat in cases where symlinks themselves need to be looked at. Based on this information I added that you should use fs.stat or fs.lstat depending on the type of file

Fixes: #47633

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 21, 2023
@mertcanaltin mertcanaltin changed the title fs: update fs.stat description doc,fs: update description of fs.stat() method Apr 21, 2023
RaisinTen
RaisinTen reviewed Apr 21, 2023
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
@mertcanaltin
Copy link
Member Author

Thank you very much for the review and corrections. @RaisinTen

mertcanaltin and others added 2 commits April 21, 2023 09:51
@mertcanaltin @RaisinTen
Update doc/api/fs.md
cc9b271 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@mertcanaltin @RaisinTen
Update doc/api/fs.md
3d9c6bd 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
RaisinTen approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @nodejs/fs

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 21, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
targos
targos reviewed Apr 21, 2023
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@mertcanaltin @targos
Update doc/api/fs.md
6208ed8 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@mertcanaltin
Copy link
Member Author

@targos Thank you very much for your suggestion, I sent a commit

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 511d40c into nodejs:main Apr 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 511d40c

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@mertcanaltin @yjl9903
doc,fs: update description of fs.stat() method
a51a292 
PR-URL: nodejs#47654
Fixes: nodejs#47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@mertcanaltin @yjl9903
doc,fs: update description of fs.stat() method
b83bdb9 
PR-URL: nodejs#47654
Fixes: nodejs#47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@mertcanaltin @yjl9903
doc,fs: update description of fs.stat() method
87f0715 
PR-URL: nodejs#47654
Fixes: nodejs#47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request May 2, 2023
@mertcanaltin @targos
doc,fs: update description of fs.stat() method
09ff9ea 
PR-URL: #47654
Fixes: #47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@mertcanaltin @danielleadams
doc,fs: update description of fs.stat() method
6bf0b00 
PR-URL: #47654
Fixes: #47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@mertcanaltin @MoLow
doc,fs: update description of fs.stat() method
8651ea8 
PR-URL: nodejs#47654
Fixes: nodejs#47633
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@daeyeon daeyeon daeyeon approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statSync fails in detecting link
9 participants
@mertcanaltin @nodejs-github-bot @lpinca @anonrig @targos @daeyeon @RaisinTen @VoltrexKeyva @LiviaMedeiros