[v18.x backport] test: assume priv ports start at 1024 if it can't be changed #46537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to test/parallel/test-cluster-bind-privileged-port.js checks the lowest privileged port to ensure 42 is privileged This only works on kernels > 4.1. On older kernels, this is locked at 1024 so the check is not needed. Fixes: nodejs#45838
|
@KrayzeeKev do you still want to land this? There are merge conflicts that need to be resolved. |
|
I'd love to see it landed either via this PR or the discussion on slack mentioned it would happen "automatically" based on the v19 patch. Since v18 is with us for a while (and we'll run it here until 20 hits LTS) and it breaks tests for RHEL-7 and anything based on it (which is us, for now), I'd really like to see it in the code. Surprised there are conflicts since nothing else has changed in that code. Unless the v19/main patch has already been applied - that'll explain why this "manual" one might cause issues. |
|
This appears to have been backported based on the v19 commit. This entire branch/PR is not required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to test/parallel/test-cluster-bind-privileged-port.js checks the lowest privileged port to ensure 42 is privileged This only works on kernels > 4.1. On older kernels, this is locked at 1024 so the check is not needed.
Fixes: #45838