tty: fix TypeError when stream is closed #43803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5697cf3 to
9e6812f
Compare
|
/cc @nodejs/tty |
joyeecheung
approved these changes
Aug 15, 2022
BridgeAR
reviewed
Aug 15, 2022
|
@BridgeAR see the linked issue, and I have also been annoyed by that error in other occasions. I struggled to find a good way to reproduce the error reliably, and I agree that the test as-is doesn't feel like something we would necessarily want to support, but the issue is real, and it looks like to me that fixing it is less problematic than not fixing it. |
|
Landed in ab89024 |
sidwebworks
pushed a commit
to sidwebworks/node
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs#41330 PR-URL: nodejs#43803 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Fixes: nodejs#41330 PR-URL: nodejs#43803 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Fixes: nodejs/node#41330 PR-URL: nodejs/node#43803 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Fixes: nodejs/node#41330 PR-URL: nodejs/node#43803 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #41335 that got stalled.
Fixes: #41330