Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc #42766

Merged
merged 2 commits into from
Apr 24, 2022
Merged

src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc #42766

merged 2 commits into from
Apr 24, 2022

Conversation

RaisinTen
Copy link
Contributor

Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com

@RaisinTen
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
fac1e81 
Refs: nodejs#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen
fixup! src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
64e8e75 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 17, 2022
dygabo
dygabo reviewed Apr 17, 2022
View reviewed changes
src/crypto/crypto_ec.cc Show resolved Hide resolved
src/crypto/crypto_ec.cc Show resolved Hide resolved
This was referenced Apr 18, 2022
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Open
22 tasks
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 22, 2022
Open
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43668/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 709d279 into nodejs:master Apr 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 709d279

@RaisinTen RaisinTen deleted the src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_ec.cc branch April 24, 2022 15:05
@github-actions github-actions bot mentioned this pull request Apr 25, 2022
Open
16 tasks
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@RaisinTen @xtx1130
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
6265d18 
Refs: nodejs#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#42766
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Open
14 tasks
This was referenced Apr 27, 2022
Open
Open
targos pushed a commit that referenced this pull request Apr 28, 2022
@RaisinTen @targos
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
494650c 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42766
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Apr 29, 2022
Open
21 tasks
@targos targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@RaisinTen @juanarbol
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
91e804f 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42766
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@RaisinTen @danielleadams
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
edeef65 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42766
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
d29aed7 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42766
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
c336ffc 
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42766
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
61cd60d 
Refs: nodejs/node#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#42766
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dygabo dygabo dygabo left review comments

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaisinTen @nodejs-github-bot @jasnell @dygabo