-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: define S_IWUSR & S_IRUSR for Windows #42748
Closed
Closed
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a5e1399
[#41591] define S_IWUSR & S_IRUSR for Windows
ilg-ul 62e3b8f
src: define S_IWUSR & S_IRUSR for Windows
ilg-ul 71fbff0
src: define S_IWUSR & S_IRUSR for Windows
ilg-ul 634f22e
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul fbe9542
src: define fs.constants.S_IWUSR & S_IRUSR for Win
ilg-ul 980862f
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul a44c0ef
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 8443080
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 25ed12a
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 5dfde98
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul cf49526
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul c20af35
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 0a772ee
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 4177c19
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 6f5760b
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul c25f5aa
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 124ef5e
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul a81c032
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul 2c546c6
Merge branch 'S_IWUSR' of https://github.com/xpack/node-fork into S_I…
ilg-ul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const fs = require('fs'); | ||
const assert = require('assert'); | ||
|
||
// Check if the two constants accepted by chmod() on Windows are defined. | ||
if (common.isWindows) { | ||
assert.ok(fs.constants.S_IRUSR !== undefined); | ||
assert.ok(fs.constants.S_IWUSR !== undefined); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be better to use
assert.notStrictEqual()
here. The "is windows?" guard is better written as:Although in its current incarnation it's not really Windows-specific. You could just remove the guard altogether and rename the file.