src: add fetch to bootstrap/browser.js

[RaisinTen]

Fixes: #41816
Signed-off-by: Darshan Sen raisinten@gmail.com

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[RaisinTen]

Hmm, seems to fail during the node_mksnapshot step:

node:internal/options:20
    ({ options: optionsMap } = getCLIOptions());
                               ^

Error: Should not query options before bootstrapping is done
    at getCLIOptionsFromBinding (node:internal/options:20:32)
    at getOptionValue (node:internal/options:40:19)
    at node:internal/bootstrap/browser:79:5

#
# Fatal error in v8::ToLocalChecked
# Empty MaybeLocal.
#

and the exception is coming from

node/src/node_options.cc

Line 942 in ceaa299

"Should not query options before bootstrapping is done");

, which was introduced in #26476.

The bootstrap script is run during compilation but the CLI option is passed at runtime.

@joyeecheung is this something we should even be doing? If so, how?

[devsnek]

options are set at runtime. bootstrapping happens at build time. if something needs to check options it should not be part of bootstrapping.

[aduh95]

I don't think this can land until we make --experimental-fetch a no op.

[RaisinTen]

Ah, yes indeed. I'm closing this because re-exposing fetch when it becomes stable should be much easier to do than fixing git conflicts in this pr.

[joyeecheung]

A trick that you can do is to add it during bootstrap unconditionally and then removing it during pre-execution when the option is not on - but yeah it’s probably still too early to do this for fetch.

[RaisinTen]

@joyeecheung yes, I did something similar in #41969.