Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 22bee2c92123 #39943

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick 22bee2c92123 #39943

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Original commit message:

[serializer] print reference stack when external reference is unknown

Print the reference stack when V8 is unable to encode an external
reference in debug builds so that it's easier for the embedder
to track the external reference down.

Refs: https://github.com/nodejs/node/pull/38905
Change-Id: Ia86eeb87833d7de0eccc7bc040301c78ddb3240c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988831
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/master@{#75546}

Refs: v8/v8@22bee2c

@joyeecheung
deps: V8: cherry-pick 22bee2c92123
8fa2cf7 
Original commit message:

    [serializer] print reference stack when external reference is unknown

    Print the reference stack when V8 is unable to encode an external
    reference in debug builds so that it's easier for the embedder
    to track the external reference down.

    Refs: nodejs#38905
    Change-Id: Ia86eeb87833d7de0eccc7bc040301c78ddb3240c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988831
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#75546}

Refs: v8/v8@22bee2c
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 30, 2021
@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2021
@targos
Copy link
Member

targos commented Aug 30, 2021

I'm going to land #39469 in a few hours and I think it includes this change.

@joyeecheung
Copy link
Member Author

@targos Ah, nice, was just working on the user-land snapshot patch and wondering when this would land because it is helpful in debugging. Thanks for the reminder, I'll close it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @targos @jasnell @cjihrig @nodejs-github-bot