Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: make node resilient to Array prototype tempering #36676

Closed
wants to merge 2 commits into from
Closed

domain: make node resilient to Array prototype tempering #36676

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 29, 2020

Fixes: #36669

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the domain Issues and PRs related to the domain subsystem. label Dec 29, 2020
@aduh95 aduh95 force-pushed the repl-array-prototype-tempering branch from 036d615 to 7068926 Compare December 29, 2020 15:13
@aduh95 aduh95 added the review wanted PRs that need reviews. label Jan 5, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35381/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35382/

@jasnell
Copy link
Member

jasnell commented Jan 9, 2021

Landed in 83b428a

@jasnell jasnell closed this Jan 9, 2021
jasnell pushed a commit that referenced this pull request Jan 9, 2021
@aduh95 @jasnell
domain: make node resilient to Array prototype tempering
83b428a 
Fixes: #36669

PR-URL: #36676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the repl-array-prototype-tempering branch January 9, 2021 22:15
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95 @danielleadams
domain: make node resilient to Array prototype tempering
9b9b6d5 
Fixes: #36669

PR-URL: #36676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
domain: make node resilient to Array prototype tempering
3f43743 
Fixes: #36669

PR-URL: #36676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. domain Issues and PRs related to the domain subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
6 participants
@aduh95 @nodejs-github-bot @jasnell @Trott @targos @Lxxyx