Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use errno constant with ERR_FS_EISDIR #35563

Closed
wants to merge 1 commit into from
Closed

fs: use errno constant with ERR_FS_EISDIR #35563

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 8, 2020

This commit updates rm() to use the EISDIR constant with ERR_FS_EISDIR instead of hard coding -21.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
fs: use errno constant with ERR_FS_EISDIR
fd8e060 
This commit updates rm() to use the EISDIR constant with
ERR_FS_EISDIR instead of hard coding -21.
@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Oct 8, 2020
@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33500/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33505/ 💚

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2020
@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2020
@github-actions
Copy link
Contributor

Landed in 71a48c3...275153d

@github-actions github-actions bot closed this Oct 10, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 10, 2020
@cjihrig @nodejs-github-bot
fs: use errno constant with ERR_FS_EISDIR
275153d 
This commit updates rm() to use the EISDIR constant with
ERR_FS_EISDIR instead of hard coding -21.

PR-URL: #35563
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig deleted the errno branch October 10, 2020 23:24
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@cjihrig @MylesBorins
fs: use errno constant with ERR_FS_EISDIR
8e3b11a 
This commit updates rm() to use the EISDIR constant with
ERR_FS_EISDIR instead of hard coding -21.

PR-URL: #35563
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@cjihrig @joesepi
fs: use errno constant with ERR_FS_EISDIR
52c7f39 
This commit updates rm() to use the EISDIR constant with
ERR_FS_EISDIR instead of hard coding -21.

PR-URL: nodejs#35563
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @bcoe @Trott @lpinca @richardlau