doc: add issue labels sections to release guide #35224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #35058 |
BethGriggs
approved these changes
Sep 16, 2020
aduh95
reviewed
Sep 16, 2020
richardlau
approved these changes
Sep 16, 2020
watilde
approved these changes
Sep 16, 2020
3 tasks
addaleax
approved these changes
Sep 16, 2020
doc/guides/releases.md
Outdated
| existing labels for that release line, such as `vN.x`. | ||
|
|
||
| If the release is transitioning from Active LTS to Maintenance, the | ||
| `backport-requested-vN.x` label must be deleted. |
There was a problem hiding this comment.
Not when it is transitioning out of Maintenance?
There was a problem hiding this comment.
I think this is to avoid getting PRs like #34950.
Trott
approved these changes
Sep 18, 2020
7152a21 to
ed8af4e
Compare
|
Landed in ed8af4e |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 21, 2020
PR-URL: #35224 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35224 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35224 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @nodejs/release