doc: update eventLoopUtilization documentation #35155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Sep 11, 2020
Comment on lines
-85
to
-86
| ELU is similar to CPU utilization except that it is calculated using high | ||
| precision wall-clock time. It represents the percentage of time the event loop |
There was a problem hiding this comment.
I might be missing something here, because the original sentence here didn’t really make sense to me – neither CPU utilization nor event loop utilization use wall-clock time?
|
@nodejs/documentation |
jasnell
approved these changes
Sep 14, 2020
Trott
approved these changes
Sep 14, 2020
|
Landed in 6eb15ce |
PR-URL: nodejs#35155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
PR-URL: #35155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes