test: improve test coverage for eventtarget #33733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b8f16c to
0d4418e
Compare
jasnell
approved these changes
Jun 5, 2020
cjihrig
approved these changes
Jun 5, 2020
19fa287 to
fd2fa69
Compare
fd2fa69 to
03068fb
Compare
Commit Queue failed- Loading data for nodejs/node/pull/33733 ✔ Done loading data for nodejs/node/pull/33733 ----------------------------------- PR info ------------------------------------ Title test: improve test coverage for eventtarget (#33733) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch juanarbol:juanarbol/event-tests -> nodejs:master Labels events, eventtarget, test Commits 1 - test: improve test coverage for eventtarget Committers 1 - Juan José Arboleda PR-URL: https://github.com/nodejs/node/pull/33733 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/33733 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: improve test coverage for eventtarget ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-05T16:27:33Z: https://ci.nodejs.org/job/node-test-pull-request/33403/ - Querying data for job/node-test-pull-request/33403/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 05 Jun 2020 02:50:26 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/33733#pullrequestreview-425283777 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/33733#pullrequestreview-425307694 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Commit Queue failed- Loading data for nodejs/node/pull/33733 ✔ Done loading data for nodejs/node/pull/33733 ----------------------------------- PR info ------------------------------------ Title test: improve test coverage for eventtarget (#33733) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch juanarbol:juanarbol/event-tests -> nodejs:master Labels events, eventtarget, test Commits 1 - test: improve test coverage for eventtarget Committers 1 - Juan José Arboleda PR-URL: https://github.com/nodejs/node/pull/33733 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/33733 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: improve test coverage for eventtarget ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-05T19:21:55Z: https://ci.nodejs.org/job/node-test-pull-request/33403/ - Querying data for job/node-test-pull-request/33403/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 05 Jun 2020 02:50:26 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/33733#pullrequestreview-425283777 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/33733#pullrequestreview-425307694 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
juanarbol
added a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #33733 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in fb2f3cc |
Merged
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #33733 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#33733 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes